Rename system profile proto's is_asan_build to is_instrumented_build and correct its definition. |
|||
Issue description1. Rename the proto's is_asan_build to is_instrumented_build, to reflect its intended meaning (without changing the ordinal). 2. Fix the MetricsLog implementation to set that value both for ASAN and DCHECK-enabled[1] builds. [1] TBD: Do we prefer to set the flag based on DCHECK_IS_CONFIGURABLE, or DCHECK_IS_ON(), or whether LOG_DCHECK == LOG_FATAL at run-time?
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/720413e7f4f9b9caa167ec35576e0d1fad59571d commit 720413e7f4f9b9caa167ec35576e0d1fad59571d Author: Wez <wez@chromium.org> Date: Thu Oct 04 17:04:31 2018 Set is_asan_build also in DCHECK-enabled binaries. SystemProfile.is_asan_build was previously only set for ASAN builds. In general we care about whether a build is standard, versus instrumented, regardless of the kind of instrumentation, so we re-use this field to also indicate DCHECK-enabled builds. The field will be renamed to is_instrumented_build up-stream, to better reflect its intended meaning. Bug: 889105 Change-Id: Ieb0c54dcf53db298a101d29447987791e9b085e1 Reviewed-on: https://chromium-review.googlesource.com/c/1260516 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#596720} [modify] https://crrev.com/720413e7f4f9b9caa167ec35576e0d1fad59571d/components/metrics/metrics_log.cc [modify] https://crrev.com/720413e7f4f9b9caa167ec35576e0d1fad59571d/components/metrics/metrics_log_unittest.cc
,
Oct 8
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7b1b61a49202b5e9fc2fde0e8690d209c24e907 commit e7b1b61a49202b5e9fc2fde0e8690d209c24e907 Author: Wez <wez@chromium.org> Date: Mon Oct 22 18:17:22 2018 Sync metrics protos with google3 - Adds keyword-suggestions fields to omnibox_event.proto. - Renames is_asan_build to is_instrumented_build. Bug: 889105 , 837395 Change-Id: Ic3264ff6052af46770ce63df2d7a189c5643ace3 Reviewed-on: https://chromium-review.googlesource.com/c/1292849 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Kevin Bailey <krb@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#601653} [modify] https://crrev.com/e7b1b61a49202b5e9fc2fde0e8690d209c24e907/components/metrics/metrics_log.cc [modify] https://crrev.com/e7b1b61a49202b5e9fc2fde0e8690d209c24e907/components/metrics/metrics_log_unittest.cc [modify] https://crrev.com/e7b1b61a49202b5e9fc2fde0e8690d209c24e907/third_party/metrics_proto/README.chromium [modify] https://crrev.com/e7b1b61a49202b5e9fc2fde0e8690d209c24e907/third_party/metrics_proto/omnibox_event.proto [modify] https://crrev.com/e7b1b61a49202b5e9fc2fde0e8690d209c24e907/third_party/metrics_proto/system_profile.proto
,
Oct 22
|
|||
►
Sign in to add a comment |
|||
Comment 1 by asvitk...@chromium.org
, Sep 25