New issue
Advanced search Search tips

Issue 889104 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 867488



Sign in to add a comment

[EoS] Work item - Get the catalog from the network for Explore on Sites

Project Member Reported by petewil@chromium.org, Sep 25

Issue description

As part of the EoS feature, we need to get a fresh catalog from the network.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fce6b968877de9af18be072706b52babbfbaaad5

commit fce6b968877de9af18be072706b52babbfbaaad5
Author: Pete Williamson <petewil@chromium.org>
Date: Thu Sep 27 04:24:32 2018

Get the catalog from the network

Uses the ExploreSitesFetcher to get the latest catalog from the network,
and upload it into our database for use on next run of ExploreSites.

Bug:  889104 
Change-Id: I2d414e6cea59271252fa735bd59191706dead377
Reviewed-on: https://chromium-review.googlesource.com/1243673
Commit-Queue: Peter Williamson <petewil@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594589}
[modify] https://crrev.com/fce6b968877de9af18be072706b52babbfbaaad5/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java
[modify] https://crrev.com/fce6b968877de9af18be072706b52babbfbaaad5/chrome/browser/android/explore_sites/explore_sites_bridge.cc
[modify] https://crrev.com/fce6b968877de9af18be072706b52babbfbaaad5/chrome/browser/android/explore_sites/explore_sites_service.h
[modify] https://crrev.com/fce6b968877de9af18be072706b52babbfbaaad5/chrome/browser/android/explore_sites/explore_sites_service_factory.cc
[modify] https://crrev.com/fce6b968877de9af18be072706b52babbfbaaad5/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/fce6b968877de9af18be072706b52babbfbaaad5/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[add] https://crrev.com/fce6b968877de9af18be072706b52babbfbaaad5/chrome/browser/android/explore_sites/explore_sites_service_impl_unittest.cc
[modify] https://crrev.com/fce6b968877de9af18be072706b52babbfbaaad5/chrome/browser/android/explore_sites/explore_sites_types.h
[modify] https://crrev.com/fce6b968877de9af18be072706b52babbfbaaad5/chrome/browser/android/explore_sites/import_catalog_task.cc
[modify] https://crrev.com/fce6b968877de9af18be072706b52babbfbaaad5/chrome/browser/android/explore_sites/import_catalog_task.h
[modify] https://crrev.com/fce6b968877de9af18be072706b52babbfbaaad5/chrome/browser/android/explore_sites/import_catalog_task_unittest.cc
[modify] https://crrev.com/fce6b968877de9af18be072706b52babbfbaaad5/chrome/test/BUILD.gn

Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45d63e73d8d73bc1603cfea231290bb1518588e1

commit 45d63e73d8d73bc1603cfea231290bb1518588e1
Author: Justin DeWitt <dewittj@chromium.org>
Date: Mon Oct 01 19:53:40 2018

[EoS] Fix test so that duplicate catalog imports are not required.

Also document GetCatalogTask and update the version checking logic to
be more accurate and clearer.

Bug:  889104 
Change-Id: I2467dd767c7a19e5454d4b31412061ea884b2b7e
Reviewed-on: https://chromium-review.googlesource.com/1254741
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595518}
[modify] https://crrev.com/45d63e73d8d73bc1603cfea231290bb1518588e1/chrome/browser/android/explore_sites/explore_sites_bridge.cc
[modify] https://crrev.com/45d63e73d8d73bc1603cfea231290bb1518588e1/chrome/browser/android/explore_sites/explore_sites_service_impl_unittest.cc
[modify] https://crrev.com/45d63e73d8d73bc1603cfea231290bb1518588e1/chrome/browser/android/explore_sites/explore_sites_types.h
[modify] https://crrev.com/45d63e73d8d73bc1603cfea231290bb1518588e1/chrome/browser/android/explore_sites/get_catalog_task.cc
[modify] https://crrev.com/45d63e73d8d73bc1603cfea231290bb1518588e1/chrome/browser/android/explore_sites/get_catalog_task.h
[modify] https://crrev.com/45d63e73d8d73bc1603cfea231290bb1518588e1/chrome/browser/android/explore_sites/get_catalog_task_unittest.cc
[modify] https://crrev.com/45d63e73d8d73bc1603cfea231290bb1518588e1/chrome/browser/android/explore_sites/import_catalog_task.cc
[modify] https://crrev.com/45d63e73d8d73bc1603cfea231290bb1518588e1/chrome/browser/android/explore_sites/import_catalog_task_unittest.cc

Sign in to add a comment