some keyboard / shortcut related interactive_ui_tests fail / timeout with Mash |
|||
Issue descriptionThe following test cases fail when --enable-features=SingleProcessMash is specified. Looks like common -- text input, keyboard events, or shortcut handling seems involved. I am not sure if there is a single core part which can fix all of them or they need to be fixed individually. fail: BrowserCommandControllerInteractiveTest.KeyEventsShouldBeConsumedByWebPageInBrowserFullscreen BrowserCommandControllerInteractiveTest.KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForEsc BrowserCommandControllerInteractiveTest.KeyEventsShouldBeConsumedByWebPageInJsFullscreenExceptForF11 KeyboardLockInteractiveBrowserTest.ActiveWithAllKeysLocked KeyboardLockInteractiveBrowserTest.ActiveWithSomeKeysLocked KeyboardLockInteractiveBrowserTest.CancelActiveKeyboardLockInFullscreen KeyboardLockInteractiveBrowserTest.SubsequentLockCallSupersedesPreviousCall OmniboxViewViewsTest.DeactivateTouchEditingOnExecuteCommand OmniboxViewViewsTest.SelectAllOnTap SitePerProcessTextInputManagerTest.CorrectlyShowVirtualKeyboardIfEnabled StickyKeysBrowserTest.CtrlClickHomeButton StickyKeysBrowserTest.OpenNewTabs StickyKeysBrowserTest.OpenTrayMenu StickyKeysBrowserTest.OverlayShown StickyKeysBrowserTest.SearchLeftOmnibox timeout: BrowserCommandControllerInteractiveTest.ShortcutsShouldTakeEffectInBrowserFullscreen BrowserKeyEventsTest.CtrlKeyEvents TextInput_SurroundingTextChangedTest.FocusToTextContainingTextAreaByClickingCase TextInput_SurroundingTextChangedTest.SurroundingTextChangedWithComposition TextInput_SurroundingTextChangedTest.SurroundingTextChangedWithInsertText
,
Sep 29
StickyKeysBrowserTest seems different, reported another issue 890536
,
Oct 2
KeyboardLockInteractiveBrowserTest has its own issue: issue 891473 BrowserCommandControllerInteractiveTest also will be resolved along with issue 891489
,
Oct 23
After fixing 891489 the following still fail: -SitePerProcessTextInputManagerTest.CorrectlyShowVirtualKeyboardIfEnabled -TextInput_SurroundingTextChangedTest.FocusToTextContainingTextAreaByClickingCase -TextInput_SurroundingTextChangedTest.SurroundingTextChangedWithComposition -TextInput_SurroundingTextChangedTest.SurroundingTextChangedWithInsertText I think the first is likely because of the keyboard not being wired up. I'll take a look as to why the remaining ones are failing.
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb75953cbb8f1d313968ab8038f695efca0e3b46 commit bb75953cbb8f1d313968ab8038f695efca0e3b46 Author: Scott Violet <sky@chromium.org> Date: Tue Oct 23 21:29:40 2018 chromeos: update test expectations for single-process-mash All of these tests now pass. BUG= 889101 , 891489 TEST=test only change Change-Id: I3f71af680c57c6e4c584156d098fad07f351b27b Reviewed-on: https://chromium-review.googlesource.com/c/1297059 Reviewed-by: Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#602106} [modify] https://crrev.com/bb75953cbb8f1d313968ab8038f695efca0e3b46/testing/buildbot/filters/chromeos.single_process_mash.interactive_ui_tests.filter
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/888842918959fc9f3e4028fd9c43702711fd9298 commit 888842918959fc9f3e4028fd9c43702711fd9298 Author: Scott Violet <sky@chromium.org> Date: Tue Oct 23 23:23:39 2018 chromeos: makes InputMethodMus notify observers when caret bounds change Which is used in some tests. BUG= 889101 TEST=covered by tests Change-Id: I74e191dd1bb7576d382e57b10f119bb4f6d4457b Reviewed-on: https://chromium-review.googlesource.com/c/1297404 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#602171} [modify] https://crrev.com/888842918959fc9f3e4028fd9c43702711fd9298/testing/buildbot/filters/chromeos.single_process_mash.interactive_ui_tests.filter [modify] https://crrev.com/888842918959fc9f3e4028fd9c43702711fd9298/ui/aura/mus/input_method_mus.cc
,
Oct 24
This should now be fixed.
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ab45c13eaf0b901732a59d3729076e500e02fee commit 3ab45c13eaf0b901732a59d3729076e500e02fee Author: Scott Violet <sky@chromium.org> Date: Wed Oct 24 02:59:24 2018 chromeos: makes InputMethodMus notify observers when virtual keyboard shown Which is used in some tests. BUG= 889101 TEST=covered by tests Change-Id: I2757361aed21909b8020fe0f9e7c600fe88f950c Reviewed-on: https://chromium-review.googlesource.com/c/1297408 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#602237} [modify] https://crrev.com/3ab45c13eaf0b901732a59d3729076e500e02fee/testing/buildbot/filters/chromeos.single_process_mash.interactive_ui_tests.filter [modify] https://crrev.com/3ab45c13eaf0b901732a59d3729076e500e02fee/ui/aura/mus/input_method_mus.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by mukai@chromium.org
, Sep 25