New issue
Advanced search Search tips

Issue 889097 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 883523



Sign in to add a comment

some TabScrubberTest fails with Mash

Project Member Reported by mukai@chromium.org, Sep 25

Issue description

The following test cases in interactive_ui_tests fail when --enable-features=SingleProcessMash is specified.

failed:
TabScrubberTest.CloseBrowser
TabScrubberTest.DeleteBeforeHighlighted
TabScrubberTest.DeleteHighlighted
TabScrubberTest.MoveAfter
TabScrubberTest.MoveBefore
TabScrubberTest.MoveHighlighted
TabScrubberTest.RTLMoveBefore

timeout:
TabScrubberTest.Bounds
TabScrubberTest.FullScreenBrowser
TabScrubberTest.Multi
TabScrubberTest.MultiBrowser
TabScrubberTest.Repeated
TabScrubberTest.RTLMulti
TabScrubberTest.RTLSkipped
TabScrubberTest.Single
TabScrubberTest.Skipped

 
Cc: mukai@chromium.org
Owner: sky@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebc304557e0c849421af611db0a72f93740a3541

commit ebc304557e0c849421af611db0a72f93740a3541
Author: Scott Violet <sky@chromium.org>
Date: Wed Oct 24 23:36:52 2018

chromeos: gets TabScrubber tests working with mash

Many of these tests previously worked by using a pattern such as:
. make TabScrubbers timer use a zero delay.
. generate a bunch of async scroll events (using EventGenerator)
. record when active tab changes.
. run message loop, waiting for active tab to change to certain index,
  then stop.

This is problematic in the mash case as EventGenerator, for mash, runs
a message loop. This meant the timer would fire at unexpected times.

The fix is to increase the timer delay, generate a single event and then
force the TabScrubber timer to complete. This way the test gets consistent
results, regardless of whether EventGenerator internally runs a message
loop.

BUG= 889097 , 890050 
TEST=test only changes

Change-Id: I5decb690c4ef7ff67af21cc9a588aaa5046fad89
Reviewed-on: https://chromium-review.googlesource.com/c/1297288
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602522}
[modify] https://crrev.com/ebc304557e0c849421af611db0a72f93740a3541/ash/system/user/tray_user_unittest.cc
[modify] https://crrev.com/ebc304557e0c849421af611db0a72f93740a3541/chrome/browser/ui/ash/tab_scrubber.cc
[modify] https://crrev.com/ebc304557e0c849421af611db0a72f93740a3541/chrome/browser/ui/ash/tab_scrubber.h
[modify] https://crrev.com/ebc304557e0c849421af611db0a72f93740a3541/chrome/browser/ui/ash/tab_scrubber_browsertest.cc
[modify] https://crrev.com/ebc304557e0c849421af611db0a72f93740a3541/ui/events/test/event_generator.cc
[modify] https://crrev.com/ebc304557e0c849421af611db0a72f93740a3541/ui/events/test/event_generator.h

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14b59c77a1ead9b81f4d563c11665fd22890acfc

commit 14b59c77a1ead9b81f4d563c11665fd22890acfc
Author: Jun Mukai <mukai@chromium.org>
Date: Fri Oct 26 06:11:18 2018

Re-enable TabScrubberTests for SingleProcessMash

BUG= 889097 
TEST=single_process_mash_interactive_ui_tests
R=sky@chromium.org

Change-Id: If6bc4ffa7c3e97cadf7eb1ce1bdfc371a034e322
Reviewed-on: https://chromium-review.googlesource.com/c/1300757
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602996}
[modify] https://crrev.com/14b59c77a1ead9b81f4d563c11665fd22890acfc/testing/buildbot/filters/chromeos.single_process_mash.interactive_ui_tests.filter

Sign in to add a comment