New issue
Advanced search Search tips

Issue 889093 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 911776
Owner:
Closed: Dec 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility

Blocked on: View detail
issue 888145
issue 891773

Blocking:
issue 883523
issue 898658



Sign in to add a comment

Make select-to-speak work with SingleProcessMash

Project Member Reported by mukai@chromium.org, Sep 25

Issue description

The following tests in interactive_ui_tests timeout when --enable-features=SingleProcessMash is specified.

SelectToSpeakTest.BreaksAtParagraphBounds
SelectToSpeakTest.ContinuesReadingDuringResize
SelectToSpeakTest.FocusRingMovesWithMouse
SelectToSpeakTest.ReadsStaticTextWithoutInlineTextChildren
SelectToSpeakTest.SelectToSpeakTrayNotSpoken
SelectToSpeakTest.SmoothlyReadsAcrossFormattedText
SelectToSpeakTest.SmoothlyReadsAcrossInlineUrl
SelectToSpeakTest.SmoothlyReadsAcrossMultipleLines
SelectToSpeakTest.SpeakStatusTray
SelectToSpeakTest.WorksWithStickyKeys
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxNextTabRecovery/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.ChromeVoxShiftSearch/1
TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/0
TestAsNormalAndGuestUser/SpokenFeedbackTest.FocusToolbar/1


They all get blocked in chromeos::SpeechMonitor::GetNextUtterance, the next utterance never appears for some reasons (i.e. WillSpeakUtterarnceWithVoice method is not called). Needs to find the reason why.
 
Blocking: 883523
GuestSpokenFeedbackTest.FocusToolbar also fails on the same reason.
SelectToSpeakTest cases are not timed out anymore (they still fail due to  issue 888750  though). This remains open since SpokenFeedbackTest and GuestSpokenFeedkbackTest still timeouts.  Maybe we should apply the same fix to them?
Cc: katie@chromium.org
katie@ made the fix for fixing the timeout for SelectToSpeakTest, just cc-ing.
Labels: Hotlist-ConOps-CrOS
TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/0 and TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode/1 are also failing.
Cc: mukai@chromium.org
Owner: jamescook@chromium.org
These will probably keep failing until we make some changes to accessibility node tree support. I'm talking to dmazzoni and dtseng about this now. I'll take this bug.

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/999ba2f0c1a11331937ff2c3985a6bd340abfc9a

commit 999ba2f0c1a11331937ff2c3985a6bd340abfc9a
Author: Jun Mukai <mukai@chromium.org>
Date: Mon Oct 01 22:01:26 2018

Suppress TestAsNormalAndGuestUser/SpokenFeedbackTest.OverviewMode

These tests are now failing on the bots due to the same reason
as other SpokenFeedbackTests.

BUG= 889093 
TEST=none

Change-Id: I1d3ac92f103e5aaf087fa0cb63ac88ceb5b8f631
Reviewed-on: https://chromium-review.googlesource.com/1252337
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595552}
[modify] https://crrev.com/999ba2f0c1a11331937ff2c3985a6bd340abfc9a/testing/buildbot/filters/chromeos.single_process_mash.interactive_ui_tests.filter

Cc: -jamescook@chromium.org
Status: Started (was: Assigned)
Summary: Make select-to-speak work with SingleProcessMash (was: SelectToSpeakTest and SpokenFeedbackTest timeout with Mash)
I suspect these are failing due to a hit test problem. I'll look and see if there's something simple we can do for SingleProcessMash.

Blockedon: 891773
Status: Assigned (was: Started)
There's no simple fix for this. We need per-widget ui::AXTreeIDs. Marking issue 891773 as blocking.

Blocking: 898658
Blockedon: 888145
Mergedinto: 911776
Status: Duplicate (was: Assigned)
This will get fixed with the "fence hopping" accessibility serializer.
Labels: -Hotlist-ConOps-CrOS

Sign in to add a comment