New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 889055 link

Starred by 1 user
Status: Closed
Owner:
█ zakerinasab@chromium.org
Last visit > 30 days ago
Closed: Sep 25
Cc:
fs...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 634542



Sign in to add a comment

Avoid passing similar source and destination color profiles to skcms_Transform

Project Member Reported by zakerinasab@chromium.org, Sep 25 
skcms_Transform does not go through the fast code path if the source and destination skcms_ICCProfile* are similar profiles but point to different objects. 3x performance regression was observed in crbug.com/886670.

To avoid this, we should always use skcms_ApproximatelyEqualProfiles() to find out if the source and destination color profiles are the same, and if so, replace them with nullptr.

Comment 1 by zakerinasab@chromium.org, Sep 25

Status: Closed (was: Assigned)
AFAICT all the current call sites of skcms_Transform do have the proper equality check for the color profiles before passing them in. The only suspect was SkiaColorTransform::Transform(), for which the owner (ccameron@) has been informed to change the code if necessary. Closing this bug.
►

Sign in to add a comment