New issue
Advanced search Search tips

Issue 889018 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 28
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-09-25
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

ChromeVox activates nodes marked as role menuitem

Project Member Reported by dtseng@chromium.org, Sep 25

Issue description

- navigate within Gmail's message view (i.e. open a message thread)
- Search+Right with ChromeVox

result:
get stuck within message header details
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f3264821fdaae92332804fbe1143d8756c799ad

commit 1f3264821fdaae92332804fbe1143d8756c799ad
Author: David Tseng <dtseng@chromium.org>
Date: Tue Sep 25 19:02:05 2018

Do not call doDefault for action verb select

In Blink, select (default action verb) often equates with 'click'.

A page author can quite reasonably have a node with role menuitem and add a click listener. In this instances, Blink gives us default action verb select.

ChromeVox calls do default and triggers undesirable side effects.

Bug:  889018 
Test: manually on Gmail.
Change-Id: I774001aa355ecaa64dd45878f40828f63feecd1a
Reviewed-on: https://chromium-review.googlesource.com/1241843
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594036}
[modify] https://crrev.com/1f3264821fdaae92332804fbe1143d8756c799ad/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Labels: Merge-Request-70
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 26

Labels: -Merge-Request-70 Hotlist-Merge-Reject Merge-Reject-70
The bug is marked as P3 or Feature. It should not be merged as M70 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Pri-3 -Hotlist-Merge-Reject -Merge-Reject-70 Merge-Request-70 Pri-1
Sorry. I filed this bug and didn't adjust the appropriate field. This issue has been widely reported by ChromeVox users and impacts usage of Gmail at a fundamental level. Navigating unintentionally triggers menu items to be activated resulting in navigation getting stuck. This change only impacts ChromeVox.
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 26

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 28

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/130b0fd2e77039b715c7d51dc6edb97b0601093f

commit 130b0fd2e77039b715c7d51dc6edb97b0601093f
Author: David Tseng <dtseng@chromium.org>
Date: Fri Sep 28 00:19:08 2018

Merge to m70: Do not call doDefault for action verb select

In Blink, select (default action verb) often equates with 'click'.

A page author can quite reasonably have a node with role menuitem and add a click listener. In this instances, Blink gives us default action verb select.

ChromeVox calls do default and triggers undesirable side effects.

TBR=dtseng@chromium.org
(cherry picked from commit 1f3264821fdaae92332804fbe1143d8756c799ad)

Bug:  889018 
Test: manually on Gmail.
Change-Id: I774001aa355ecaa64dd45878f40828f63feecd1a
Reviewed-on: https://chromium-review.googlesource.com/1241843
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#594036}
Reviewed-on: https://chromium-review.googlesource.com/1250204
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#722}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/130b0fd2e77039b715c7d51dc6edb97b0601093f/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/130b0fd2e77039b715c7d51dc6edb97b0601093f

Commit: 130b0fd2e77039b715c7d51dc6edb97b0601093f
Author: dtseng@chromium.org
Commiter: dtseng@chromium.org
Date: 2018-09-28 00:19:08 +0000 UTC

Merge to m70: Do not call doDefault for action verb select

In Blink, select (default action verb) often equates with 'click'.

A page author can quite reasonably have a node with role menuitem and add a click listener. In this instances, Blink gives us default action verb select.

ChromeVox calls do default and triggers undesirable side effects.

TBR=dtseng@chromium.org
(cherry picked from commit 1f3264821fdaae92332804fbe1143d8756c799ad)

Bug:  889018 
Test: manually on Gmail.
Change-Id: I774001aa355ecaa64dd45878f40828f63feecd1a
Reviewed-on: https://chromium-review.googlesource.com/1241843
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#594036}
Reviewed-on: https://chromium-review.googlesource.com/1250204
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#722}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Status: Fixed (was: Started)

Sign in to add a comment