New issue
Advanced search Search tips

Issue 889012 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Grey patch is displayed in bookmark search screen on changing the device orientation from landscape to portrait mode.

Project Member Reported by pmadalla@chromium.org, Sep 25

Issue description

App Version: 71.0.3561.0 Canary
iOS Version: 10.3.3,iOS 12
Device: iPhones only

Precondition:
1- Have some bookmarks saved

Steps to reproduce:
1. Launch Chrome in Portrait mode.
2. Tap on Menu > Bookmarks > Mobile Bookmarks 
3. Tap on Search > Scroll down
4. Change the device orientation to landscape mode.
  
Observed results: 
Grey patch is displayed. 

Expected results: 
Grey patch should be dismissed once the keyboard is dismissed.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA    
Bug reproducible on Dolphin/Safari/Firefox: Safari : NA
Bug reproducible on the current beta channel build : NA New Implementation in  M71
Bug reproducible on the current beta channel build : NA New Implementation in  M71

Link to video/image: 

Video :
https://drive.google.com/file/d/1cUAJY7WF2puXvz65pOmaKQLlan4qj2sO/view?usp=sharing

Image :
https://drive.google.com/file/d/1NQNlBGA3GqbjHuODuki1C7_OsGbscV_3/view?usp=sharing

 
Cc: sczs@chromium.org
Labels: -Pri-3 Pri-2
Owner: djean@chromium.org
Status: Assigned (was: Untriaged)
djean@ could you PTAL?
Labels: -Proj-UIRefreshMS-Bookmarks MS-Bookmarks Proj-UIRefresh
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12234dec99844811341abe269be29519ebab735b

commit 12234dec99844811341abe269be29519ebab735b
Author: David Jean <djean@google.com>
Date: Tue Oct 02 07:32:59 2018

[ios] Fixed history/bookmarks scrim issues

- Resize on rotation.
- Disable scrolling of table when active.

Bug:  889012 ,889506,  889461 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I54d4f41d31a0fb3ec7e248a3cb25bb985e58cf72
Reviewed-on: https://chromium-review.googlesource.com/1249483
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595750}
[modify] https://crrev.com/12234dec99844811341abe269be29519ebab735b/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm
[modify] https://crrev.com/12234dec99844811341abe269be29519ebab735b/ios/chrome/browser/ui/history/history_table_view_controller.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified the issue on the build version 71.0.3574.0 canary tested on iPhone7+(iOS 12.0.1) and iPhone 6(iOS 10.3.3).
Shaded area is dismissed when we try to scroll the bookmarks search looks good.

Sign in to add a comment