New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 889011 link

Starred by 3 users
Status: Fixed
Owner:
fbeaufort@chromium.org
Closed: Sep 26
Cc:
█ mlamo...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Picture-in-Picture should not close if an older pip tab is closed

Project Member Reported by fbeaufort@chromium.org, Sep 25 
Chrome Version: 71.0.3558.0 (Official Build) canary (64-bit)
OS: 11092.0.0 (Official Build) canary-channel eve

What steps will reproduce the problem?
(1) Go to https://googlechrome.github.io/samples/picture-in-picture/ in tab A
(2) Play video and enter PiP in tab A
(3) Open a new tab B to https://googlechrome.github.io/samples/picture-in-picture/
(4) Play video and enter PiP in tab B
(5) Close tab A

What is the expected result?
PiP video from tab B should continue to play.

What happens instead?
PiP window closes.

Comment 1 by fbeaufort@chromium.org, Sep 25

Cc: mlamo...@google.com
What a pleasant surprise! This is actually fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1236276

The DCHECK crash was actually a real bug.
Yeah! https://bugs.chromium.org/p/chromium/issues/detail?id=879592

Comment 2 Deleted

Comment 3 Deleted

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/831a1ec9ca49586b323d13d4e9b11c355deff761

commit 831a1ec9ca49586b323d13d4e9b11c355deff761
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Wed Sep 26 19:52:10 2018

[Picture-in-Picture] Reset MediaPlayerId when user closes PiP window.

This makes sure the MediaPlayerId of the Picture-in-Picture video is
reset when user closes Picture-in-Picture window manually or when user
requests Picture-in-Picture several times.

Bug:  879592 ,  889011 
Change-Id: I3ceea8de7fc5ee0e2c81268154daaa065b29b92b
Reviewed-on: https://chromium-review.googlesource.com/1236276
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#594441}
[modify] https://crrev.com/831a1ec9ca49586b323d13d4e9b11c355deff761/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/831a1ec9ca49586b323d13d4e9b11c355deff761/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/831a1ec9ca49586b323d13d4e9b11c355deff761/content/browser/media/media_web_contents_observer.h
[modify] https://crrev.com/831a1ec9ca49586b323d13d4e9b11c355deff761/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc

Comment 5 by mlamouri@chromium.org, Sep 26

Owner: fbeaufort@chromium.org
Status: Fixed (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 4

Labels: merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09b2b7de767653f017ac4dfecbc133e830e276d1

commit 09b2b7de767653f017ac4dfecbc133e830e276d1
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Thu Oct 04 07:37:11 2018

[Picture-in-Picture] Reset MediaPlayerId when user closes PiP window.

This makes sure the MediaPlayerId of the Picture-in-Picture video is
reset when user closes Picture-in-Picture window manually or when user
requests Picture-in-Picture several times.

Bug:  879592 ,  889011 
Change-Id: I3ceea8de7fc5ee0e2c81268154daaa065b29b92b
Reviewed-on: https://chromium-review.googlesource.com/1236276
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Original-Commit-Position: refs/heads/master@{#594441}(cherry picked from commit 831a1ec9ca49586b323d13d4e9b11c355deff761)
Reviewed-on: https://chromium-review.googlesource.com/c/1260129
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/branch-heads/3538@{#848}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/09b2b7de767653f017ac4dfecbc133e830e276d1/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/09b2b7de767653f017ac4dfecbc133e830e276d1/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/09b2b7de767653f017ac4dfecbc133e830e276d1/content/browser/media/media_web_contents_observer.h
[modify] https://crrev.com/09b2b7de767653f017ac4dfecbc133e830e276d1/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
►

Sign in to add a comment