New issue
Advanced search Search tips

Issue 889009 link

Starred by 2 users
Status: Untriaged
Owner:
delph...@chromium.org
Cc:
leszeks@chromium.org
rmcilroy@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add blink snapshot strings to RO-space

Project Member Reported by leszeks@chromium.org, Sep 25 
Currently RO-space is marked ReadOnly when deserialization completes. However, the blink snapshot works by deserializing the V8 snapshot, adding more stuff, and re-serializing, which means that nothing new is added to RO-space.

Blink old-space has about ~60K of internalized strings not present in V8 old-space, so probably most of those would end up in RO-space if we opened it.

Comment 1 by delph...@chromium.org, Sep 25 

RO_SPACE is basically closed at this point: https://cs.chromium.org/chromium/src/v8/src/isolate.cc?sq=package:chromium&g=0&l=3041
which is around the end of Isolate creation.

To capture this strings, we would need to close RO_SPACE later during snapshot generation. Perhaps even not close it all?

Comment 2 by leszeks@chromium.org, Sep 25 

Maybe wrap the whole snapshot generator code in a WritableScope (and change that to a counter rather than simple close-on-destruct)?
►

Sign in to add a comment