Flaky test: DevToolsAutoOpenerTest.TestAutoOpenForTabs Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=4028b7f2e7276110 Test output log: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ASan%20LSan%20Tests%20%281%29/50041 Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/Iec737aac74fb62118d07b6cf878a14db055f5be5 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyrAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ2Y2hyb21pdW0ubWVtb3J5L0xpbnV4IEFTYW4gTFNhbiBUZXN0cyAoMSkvNTAwNDEvYnJvd3Nlcl90ZXN0cy9SR1YyVkc5dmJITkJkWFJ2VDNCbGJtVnlWR1Z6ZEM1VVpYTjBRWFYwYjA5d1pXNUdiM0pVWVdKegwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20DevToolsAutoOpenerTest.TestAutoOpenForTabs&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyrAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ2Y2hyb21pdW0ubWVtb3J5L0xpbnV4IEFTYW4gTFNhbiBUZXN0cyAoMSkvNTAwNDEvYnJvd3Nlcl90ZXN0cy9SR1YyVkc5dmJITkJkWFJ2VDNCbGJtVnlWR1Z6ZEM1VVpYTjBRWFYwYjA5d1pXNUdiM0pVWVdKegwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
Revert is out in https://chromium-review.googlesource.com/c/chromium/src/+/1243084
Revert landed.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de60d0c16185372421a46c78f74e8e4a5fdfea20 commit de60d0c16185372421a46c78f74e8e4a5fdfea20 Author: Alex Clarke <alexclarke@chromium.org> Date: Tue Sep 25 16:53:48 2018 Reland "Make Chrome_DevToolsADBThread shutdown gracefully in tests" Relanding https://chromium-review.googlesource.com/c/chromium/src/+/1238468 The fix can be seen in the delta between patch set 1 and 2. Original patch description: Make Chrome_DevToolsADBThread shutdown gracefully in tests To land the BrowserUIThreadScheduler we need in tests for all threads to stop using base::PostTaskWithTraits before the scheduler is deleted. Currently this is true for the UI and IO threads but it's not true for Chrome_DevToolsADBThread. This patch makes sure references retaining AndroidDeviceManager::HandlerThread are released in tests which triggers thread shutdown, fixing the problem. TBR=dgozman@chromium.org,finnur@chromium.org,mlamouri@chromium.org Bug: 863341, 872372, 888994 Change-Id: Ie9298d652cad2df6ad93d19cfb3dd5b76fdcf339 Reviewed-on: https://chromium-review.googlesource.com/1243115 Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#593970} [modify] https://crrev.com/de60d0c16185372421a46c78f74e8e4a5fdfea20/chrome/browser/devtools/chrome_devtools_manager_delegate.cc [modify] https://crrev.com/de60d0c16185372421a46c78f74e8e4a5fdfea20/chrome/browser/devtools/chrome_devtools_manager_delegate.h [modify] https://crrev.com/de60d0c16185372421a46c78f74e8e4a5fdfea20/chrome/browser/devtools/device/devtools_android_bridge.cc [modify] https://crrev.com/de60d0c16185372421a46c78f74e8e4a5fdfea20/chrome/browser/devtools/device/devtools_android_bridge.h [modify] https://crrev.com/de60d0c16185372421a46c78f74e8e4a5fdfea20/chrome/browser/devtools/devtools_sanity_browsertest.cc [modify] https://crrev.com/de60d0c16185372421a46c78f74e8e4a5fdfea20/chrome/browser/devtools/devtools_window_testing.cc [modify] https://crrev.com/de60d0c16185372421a46c78f74e8e4a5fdfea20/chrome/browser/extensions/extension_loading_browsertest.cc [modify] https://crrev.com/de60d0c16185372421a46c78f74e8e4a5fdfea20/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
Comment 1 by blundell@chromium.org
, Sep 25Status: Started (was: Untriaged)