New issue
Advanced search Search tips

Issue 888986 link

Starred by 2 users
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Sep 27
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] Error message is not seen for unwanted characters "+" and "E" entries in 'Scale' textfield

Reported by khushal....@etouch.net, Sep 25 
Chrome Version: 71.0.3561.0 (Official Build) Revision 59edfd1d195efd57c937c950c1fd2a708a83f1f0-refs/branch-heads/3561@{#1} (32/64 bit)
OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS)

Steps to reproduce:
1. Launch chrome and press 'Ctrl+P' to open Print Preview overlay.
2. Click on 'More Settings' to expand and click on 'Scale' field.
3. Now type character "+" or "E" in 'Scale' field and Observe.

Actual Result: Error message is not seen for unwanted characters "+" and "E" entries in 'Scale' textfield.
Expected Result: Error message should be seen for "+" and "E" entries in 'Scale' textfield.

This is a Regression issue seen from 'M-62' and will provide the bisect info soon:
Good Build: 62.0.3201.0 (Revision: 498716)
Bad Build:  62.0.3202.0 (Revision: 499098)

You are probably looking for a change made after 499091 (known good), but no later than 499092 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/713f446d43ad51079710a62e124377c37624e3aa..64a1c67781f596017fa394a82ba5902d7e9bb9a6

Suspect: https://chromium.googlesource.com/chromium/src/+/64a1c67781f596017fa394a82ba5902d7e9bb9a6

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: Issue is also seen on M-69 Stable (build #69.0.3497.100), M-70 Beta (build #70.0.3538.22) & M-70 Dev (build #71.0.3554.0).

Kindly refer the attached screen-cast.

Thank You..!!
Actual Video.mov
9.5 MB View Download
Expected Video.mov
8.2 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/957e18ed8c32465c693652d80e6166cb331e3770

commit 957e18ed8c32465c693652d80e6166cb331e3770
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Sep 26 03:22:07 2018

Print Preview Refresh: More error handling changes

(1) Add 'E' and '+' to the list of excluded keys for number inputs
(2) Blank input handling: Do not disable other settings/print button
    for a blank input. This also fixes a focus traversal issue with
    settings being immediately re-enabled on blur.
(3) Related: When enter is pressed on an input field that may be
    empty, perform the same action as on blur - i.e. reset the cleared
    field to the default value.

Bug:  888916 ,  888986 ,  886800 
Change-Id: I9cf43558fe5353939d9904594d2c39a576d27371
Reviewed-on: https://chromium-review.googlesource.com/1244372
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594208}
[modify] https://crrev.com/957e18ed8c32465c693652d80e6166cb331e3770/chrome/browser/resources/print_preview/new/copies_settings.js
[modify] https://crrev.com/957e18ed8c32465c693652d80e6166cb331e3770/chrome/browser/resources/print_preview/new/number_settings_section.html
[modify] https://crrev.com/957e18ed8c32465c693652d80e6166cb331e3770/chrome/browser/resources/print_preview/new/number_settings_section.js
[modify] https://crrev.com/957e18ed8c32465c693652d80e6166cb331e3770/chrome/browser/resources/print_preview/new/pages_settings.html
[modify] https://crrev.com/957e18ed8c32465c693652d80e6166cb331e3770/chrome/browser/resources/print_preview/new/pages_settings.js
[modify] https://crrev.com/957e18ed8c32465c693652d80e6166cb331e3770/chrome/browser/resources/print_preview/new/scaling_settings.js

Comment 2 by rbpotter@chromium.org, Sep 27

Status: Fixed (was: Assigned)
+ and E key events are now blocked. Tested on Canary 71.0.3563.0.

Comment 3 by khushal....@etouch.net, Sep 28

Labels: TE-Verified-M71 TE-Verified-71.0.3564.0
Update:

Rechecked the above issue on Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS) using latest canary #71.0.3564.0 and the issue is found FIXED.
Hence, adding TE-Verified labels.

Please refer the attached screen-cast.

Thank you..!!
Fixed Video.mov
5.4 MB View Download

Comment 4 by rbpotter@chromium.org, Sep 28

Status: Verified (was: Fixed)
►

Sign in to add a comment