Show dummy values in Password/Passphrase/PSK input fields |
|||||||
Issue descriptionWhen configuring a network (network_config.html[1]), the Password/Passphrase/PSK fields are always empty. If we have already stored a value for those input fields, we should not show these values in those input fields, but at least indicate their existence with dummy values (masked with ******* anyways). The fields still need to be editable with new values. stevenjb@ has already made a similar fix (see crbug.com/875983 ) for VPN.IPsec.PSK, we want to extend this fix to the other password/passhphrase/PSK fields as well. This should probably be included in network-password-input.html [2] [1] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_components/chromeos/network/network_config.html?q=network_config.html&sq=package:chromium&dr [2] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_components/chromeos/network/network_password_input.html?q=network-password-input&sq=package:chromium&dr=C&l=8
,
Oct 1
Assigning as a first task for the noogler. (can't actually assign yet till he'll activate account on crbug.com)
,
Oct 9
,
Oct 11
,
Oct 16
,
Nov 6
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8576e9f978d8536dee497834602ebf33f0eb1e4 commit b8576e9f978d8536dee497834602ebf33f0eb1e4 Author: Roman Aleksandrov <raleksandrov@google.com> Date: Tue Nov 13 09:42:40 2018 Show dummy values for all types of Passwords/Passphrases/PSK in case we have already stored a particular value Change-Id: I6c6b8293aa7748152a44b945f092e563643328d8 Bug: 888959 Reviewed-on: https://chromium-review.googlesource.com/c/1296540 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#607535} [modify] https://crrev.com/b8576e9f978d8536dee497834602ebf33f0eb1e4/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js [modify] https://crrev.com/b8576e9f978d8536dee497834602ebf33f0eb1e4/chromeos/network/onc/onc_merger.cc [modify] https://crrev.com/b8576e9f978d8536dee497834602ebf33f0eb1e4/chromeos/network/onc/onc_translator_shill_to_onc.cc [modify] https://crrev.com/b8576e9f978d8536dee497834602ebf33f0eb1e4/chromeos/network/policy_util.cc [modify] https://crrev.com/b8576e9f978d8536dee497834602ebf33f0eb1e4/chromeos/network/policy_util.h [modify] https://crrev.com/b8576e9f978d8536dee497834602ebf33f0eb1e4/chromeos/test/data/network/augmented_merge.json [modify] https://crrev.com/b8576e9f978d8536dee497834602ebf33f0eb1e4/ui/webui/resources/cr_components/chromeos/network/network_config.html [modify] https://crrev.com/b8576e9f978d8536dee497834602ebf33f0eb1e4/ui/webui/resources/cr_components/chromeos/network/network_config.js [modify] https://crrev.com/b8576e9f978d8536dee497834602ebf33f0eb1e4/ui/webui/resources/cr_components/chromeos/network/network_password_input.html [modify] https://crrev.com/b8576e9f978d8536dee497834602ebf33f0eb1e4/ui/webui/resources/cr_components/chromeos/network/network_password_input.js
,
Nov 19
This change allows to see that password is saved. But its particular value is not shown. To test this feature you should do the following: 1) Connect to not-configured net which requires Password/Passphrase/PSK (wifi as an example). 2) Click Configure button and you will see dots instead of Password/Passphrase/PSK. 3) Change or not change some other fields and click Save. 4) Connect to net again. Password/Passphrase/PSK will remain the same so if you have not changed something important at step 3, you should be able to connect again. Another way to see dots after clicking on Configure in Password/Passphrase/PSK field is to configure net via the policy. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 Deleted