New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 888947 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 889543



Sign in to add a comment

Native Heap Symbolizer Tests failing, blocking catapult CQ

Project Member Reported by nednguyen@chromium.org, Sep 25

Issue description

Components: Speed>Tracing
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/7931f7f4ae38599eae772a48208c0c6a3a292bbe

commit 7931f7f4ae38599eae772a48208c0c6a3a292bbe
Author: Nghia Nguyen <nednguyen@google.com>
Date: Tue Sep 25 09:49:05 2018

Disable symbolize_trace_end_to_end_test_slow.SymbolizeTraceEndToEndTest.testMacv2

Bug:  chromium:888947 
Change-Id: I335c6fd9eabc564313371f1a004f7387e85ba84a

TBR=erikchen@chromium.org, dskiba@chromium.org

Change-Id: I335c6fd9eabc564313371f1a004f7387e85ba84a
Reviewed-on: https://chromium-review.googlesource.com/1242095
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/7931f7f4ae38599eae772a48208c0c6a3a292bbe/tracing/tracing/extras/symbolizer/symbolize_trace_end_to_end_test_slow.py

Cc: u...@chromium.org
Labels: -Pri-0 Pri-1
Test is disabled, reduce this to P1
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/009b6db6a15c72b7ea80ffb0d6bc1e94843c9cdd

commit 009b6db6a15c72b7ea80ffb0d6bc1e94843c9cdd
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Sep 25 11:16:24 2018

Roll src/third_party/catapult c51eb628dd91..7931f7f4ae38 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/c51eb628dd91..7931f7f4ae38


git log c51eb628dd91..7931f7f4ae38 --date=short --no-merges --format='%ad %ae %s'
2018-09-25 nednguyen@google.com Disable symbolize_trace_end_to_end_test_slow.SymbolizeTraceEndToEndTest.testMacv2


Created with:
  gclient setdep -r src/third_party/catapult@7931f7f4ae38

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:888947 
TBR=sullivan@chromium.org

Change-Id: Ice88792fd398d4eeae9590f43f2a01283b432fc2
Reviewed-on: https://chromium-review.googlesource.com/1242324
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#593889}
[modify] https://crrev.com/009b6db6a15c72b7ea80ffb0d6bc1e94843c9cdd/DEPS

Cc: nednguyen@chromium.org sergeybe...@chromium.org
"""
xcode-select: note: no developer tools were found at '/Applications/Xcode.app', requesting install. Choose an option in the dialog to download the command line developer tools.
"""

It looks like bot configuration has changed. 

+ nednguyen -- are you aware of any changes here? 

+ sergeyberezin -- next CCI trooper -- are you aware of any changes here?


Cc: simonhatch@chromium.org
Simon is doing the LUCI migration may aware of the changes
The recipe / bot doesn't seem to install the new "hermetic" Xcode, neither through an explicit recipe step, nor through gclient runhooks. New Mac bots are now issued without system Xcode, since we expect bots to install Xcode dynamically per build.

This is similar to issue 884015, and their fix was https://crrev.com/c/1238890 plus adding the corresponding service accounts to the ACLs for Xcode - https://chrome-infra-auth.appspot.com/auth/groups/ios-xcode-readers .

The recipe module has some docs - https://cs.chromium.org/chromium/tools/depot_tools/recipes/recipe_modules/osx_sdk/api.py?l=27&rcl=aaf2cc09c6874e394c6c1e4692360cc400d6b388

And any trooper should be able to help you with the ACLs  - http://g.co/bugatrooper .
Owner: simonhatch@chromium.org
Over to simonhatch who's working on LUCI migration
I'm not super familiar with the recipe, and the LUCI migration of mac happened well over a month ago so I'm surprised this didn't pop up between then and now. From sergey's comment, it seems like I just need to copy that osx sdk dependency to the recipe and the acl's, so I'll try that.
Blockedon: 889543
Status: Assigned (was: Untriaged)
IIUC, up until very recently the machines used by the new LUCI bots were older and had Xcode installed in the system. Recently we added a few new machines, and those come without Xcode, hence the failures.
Feel free to ping me or go/luci-tf-hangout for help if needed.
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/7a4e890f252c5d5850c3312d343085260e27a691

commit 7a4e890f252c5d5850c3312d343085260e27a691
Author: Simon <simonhatch@chromium.org>
Date: Thu Sep 27 18:08:25 2018

Re-enable symbolize_trace_end_to_end_test_slow.SymbolizeTraceEndToEndTest.testMacv2

Bug:  chromium:888947 
Change-Id: I121ce66e28ec4ba6713efad3f6862b45dd997ef9
Reviewed-on: https://chromium-review.googlesource.com/1249443
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/7a4e890f252c5d5850c3312d343085260e27a691/tracing/tracing/extras/symbolizer/symbolize_trace_end_to_end_test_slow.py

Status: Fixed (was: Assigned)
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6699ff39e8bf5d307de4e88a444dcd5220227d8

commit d6699ff39e8bf5d307de4e88a444dcd5220227d8
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Sep 27 19:58:55 2018

Roll src/third_party/catapult 4e651334d46b..7a4e890f252c (1 commits)

https://chromium.googlesource.com/catapult.git/+log/4e651334d46b..7a4e890f252c


git log 4e651334d46b..7a4e890f252c --date=short --no-merges --format='%ad %ae %s'
2018-09-27 simonhatch@chromium.org Re-enable symbolize_trace_end_to_end_test_slow.SymbolizeTraceEndToEndTest.testMacv2


Created with:
  gclient setdep -r src/third_party/catapult@7a4e890f252c

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:888947 
TBR=sullivan@chromium.org

Change-Id: I122717fbc2aebcff1d1d190b2a75049b420c2d07
Reviewed-on: https://chromium-review.googlesource.com/1249634
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594830}
[modify] https://crrev.com/d6699ff39e8bf5d307de4e88a444dcd5220227d8/DEPS

Sign in to add a comment