New issue
Advanced search Search tips

Issue 888932 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 853794



Sign in to add a comment

Keyboard accessory opens a blank sheet

Project Member Reported by vasi...@chromium.org, Sep 25

Issue description

Chrome Version: 70.0.3538.27 beta
OS: Android

What steps will reproduce the problem?
(1) Open new tab
(2) Go to m.vk.com and open a chat
(3) Focus the input to type a message

I see the key icon (expected). When I click it I see a blank sheet (unexpected). Note that I have a credential saved for vk.com but I don't see anything.
 
Screenshot_20180925-094043.png
258 KB View Download
Screenshot_20180925-094039.png
335 KB View Download
Blocking: 853794
Cc: chelamcherla@chromium.org
Labels: Triaged-Mobile
Status: Assigned (was: Untriaged)
As per comment#0 changing status to Assigned, Please change if this is not the case.

Thanks!
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a447c2d08c40cc3789f8c5a83e565e3579169d3

commit 4a447c2d08c40cc3789f8c5a83e565e3579169d3
Author: Ioana Pandele <ioanap@chromium.org>
Date: Thu Sep 27 17:11:19 2018

Don't create the keyboard accessory if generation is signaled unavailable

If there is no keyboard accessory, signaling that password generation is
unavailable doesn't constitute a state update. The keyboard accessory should
only be created and initialized if there is an action or data to display.

Bug:  888932 
Change-Id: I9dbf8bd1ce4ae620f9b50e4e4aadb7c3c2335733
Reviewed-on: https://chromium-review.googlesource.com/1249084
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594761}
[modify] https://crrev.com/4a447c2d08c40cc3789f8c5a83e565e3579169d3/chrome/browser/password_manager/chrome_password_manager_client.cc

Status: Fixed (was: Started)

Sign in to add a comment