New issue
Advanced search Search tips

Issue 888930 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 644851



Sign in to add a comment

Draw single quad render pass directly

Project Member Reported by xing...@intel.com, Sep 25

Issue description

The idea is from weiliangc:
TODO(weiliangc): GL Renderer has optimization that when Render Pass has a
single quad inside we would draw that directly. We could add similar
optimization here by using the quad's SkImage.

And I will working on this.
 
Blocking: 644851
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61152b74bdd5d0b9a270e67e0831c028e2bc1649

commit 61152b74bdd5d0b9a270e67e0831c028e2bc1649
Author: Xu Xing <xing.xu@intel.com>
Date: Thu Sep 27 15:32:40 2018

viz: Draw single quad render pass directly

The idea is from:
TODO(weiliangc): GL Renderer has optimization that when Render Pass has a
single quad inside we would draw that directly. We could add similar
optimization here by using the quad's SkImage.

BUG= 888930 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I42717c8a3fcfd93671db4ccff04acb76c005fa6a
Reviewed-on: https://chromium-review.googlesource.com/1242303
Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#594731}
[modify] https://crrev.com/61152b74bdd5d0b9a270e67e0831c028e2bc1649/components/viz/service/display/direct_renderer.cc
[modify] https://crrev.com/61152b74bdd5d0b9a270e67e0831c028e2bc1649/components/viz/service/display/direct_renderer.h
[modify] https://crrev.com/61152b74bdd5d0b9a270e67e0831c028e2bc1649/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/61152b74bdd5d0b9a270e67e0831c028e2bc1649/components/viz/service/display/skia_renderer.cc
[modify] https://crrev.com/61152b74bdd5d0b9a270e67e0831c028e2bc1649/components/viz/service/display/skia_renderer.h

Status: Fixed (was: Started)

Sign in to add a comment