New issue
Advanced search Search tips

Issue 888920 link

Starred by 2 users
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Sep 27
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] Blue focus highlight of 'Search Destinations' does not touch the bottom border of text-field.

Reported by sanyam.g...@etouch.net, Sep 25 
Chrome Version: 71.0.3561.0 Revision 59edfd1d195efd57c937c950c1fd2a708a83f1f0-refs/branch-heads/3561@{#1}(32/64 bit)
OS: Windows(7, 8, 8.1 ,10), Mac (10.12.6, 10.13.1, 10.13.6, 10.14) & Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, press Ctrl + P to open print preview.
2. Click on 'Change' button to open 'Select a destination' overlay.
3. Observe the blue focus highlight of 'Search Destinations' field. 

Actual Result  : Blue Focus highlight of 'Search Destinations' does not touch the bottom border of text-field.
Expected Result: Blue Focus highlight of 'Search Destinations' should touch the bottom border of text-field.

This is a regression issue broken in ‘M-71’ and will soon update other info:
Good Build: 71.0.3559.0 (Revision: 593400)
Bad Build : 71.0.3560.0 (Revision: 593538)
Actual_Result.mp4
524 KB View Download
Expected_Result.mp4
274 KB View Download
Result.jpg
84.9 KB View Download

Comment 1 by sanyam.g...@etouch.net, Sep 25

Labels: hasbisect-per-revision
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 593402 (known good), but no later than 593403 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/8583bf4caad163dc92661347d24338692560fe07..5e659696b565b65c4b89a2d117c8b4dba5cf30f9

Suspect: https://chromium.googlesource.com/chromium/src/+/5e659696b565b65c4b89a2d117c8b4dba5cf30f9

From the CL above, assigning the issue to the concern owner 

@rbpotter - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa3d01e2e22da6189e1540e335cd02ec7b68c525

commit aa3d01e2e22da6189e1540e335cd02ec7b68c525
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Sep 26 00:48:25 2018

Print Preview Refresh: Fix input underline positioning

Bug:  888920 
Change-Id: I2bdd84dcccb1c0d925cad96e39034d448ac88bf7
Reviewed-on: https://chromium-review.googlesource.com/1244169
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594165}
[modify] https://crrev.com/aa3d01e2e22da6189e1540e335cd02ec7b68c525/chrome/browser/resources/print_preview/new/print_preview_shared_css.html

Comment 3 by rbpotter@chromium.org, Sep 27 

Tested and this is fixed in Canary 71.0.3563.0.

Comment 4 by rbpotter@chromium.org, Sep 27

Status: Fixed (was: Assigned)

Comment 5 by sanyam.g...@etouch.net, Sep 28

Labels: TE-Verified-M71 TE-Verified-71.0.3564.0
Update :
Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) OS with Canary version #71.0.3564.0 and the issue is fixed.

Kindly refer the attached screen cast.
Fixed_Behaviour.mp4
428 KB View Download

Comment 6 by rbpotter@chromium.org, Sep 28

Status: Verified (was: Fixed)
►

Sign in to add a comment