New issue
Advanced search Search tips

Issue 888904 link

Starred by 3 users
Status: Fixed
Owner:
tasak@google.com
Closed: Nov 5
Cc:
haraken@chromium.org
chrisha@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Remove memory coordinator V0

Project Member Reported by tasak@google.com, Sep 25 
Remove memory coordinator V0

We want to remove the duplicate code, memory coordinator and memory pressure listener.
Firstly we will ship memory coordinator and will remove memory pressure listener.
However unfortunately we have no plan to ship memory coordinator. So we decided to remove memory coordinator.

We are planning:
(1) For each component, replace (or just remove) memory coordinator client with memory pressure listener.
(2) After confirming that there are no components using memory coordinator, remove memory coordinator (mojom, and so on).
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/420ec97cb6d2c364a56f1d5d7859b7bb39a8d05a

commit 420ec97cb6d2c364a56f1d5d7859b7bb39a8d05a
Author: Takashi Sakamoto <tasak@google.com>
Date: Wed Sep 26 09:27:59 2018

Remove MemoryCoordinatorClient from net/

BUG= 888904 

Change-Id: Ib014a31ec6d0a205791fdf18edccbe35b38443f1
Reviewed-on: https://chromium-review.googlesource.com/1242570
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594262}
[modify] https://crrev.com/420ec97cb6d2c364a56f1d5d7859b7bb39a8d05a/net/http/http_network_session.cc
[modify] https://crrev.com/420ec97cb6d2c364a56f1d5d7859b7bb39a8d05a/net/http/http_network_session.h
[modify] https://crrev.com/420ec97cb6d2c364a56f1d5d7859b7bb39a8d05a/net/ssl/ssl_client_session_cache.cc
[modify] https://crrev.com/420ec97cb6d2c364a56f1d5d7859b7bb39a8d05a/net/ssl/ssl_client_session_cache.h
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f5372286b1b65e8f9ee377cb211a419d2ad505c

commit 7f5372286b1b65e8f9ee377cb211a419d2ad505c
Author: Takashi Sakamoto <tasak@google.com>
Date: Thu Sep 27 11:50:13 2018

Remove MemoryCoordinatorClient from components/viz.

BUG= 888904 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I5cf086f679a001ab1d87f23dbc3bd6e1213fb7f2
Reviewed-on: https://chromium-review.googlesource.com/1248381
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#594676}
[modify] https://crrev.com/7f5372286b1b65e8f9ee377cb211a419d2ad505c/components/viz/client/frame_eviction_manager.cc
[modify] https://crrev.com/7f5372286b1b65e8f9ee377cb211a419d2ad505c/components/viz/client/frame_eviction_manager.h
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9db6d6fdc4f0d5205d5b72b7902f44ed5dccb7b1

commit 9db6d6fdc4f0d5205d5b72b7902f44ed5dccb7b1
Author: Takashi Sakamoto <tasak@google.com>
Date: Wed Oct 03 07:56:51 2018

Remove MemoryCoordinatorClient from components/discardable_memory.

BUG= 888904 

Change-Id: I2b5af4b25e190a564d9374c94b6f6d43be84da58
Reviewed-on: https://chromium-review.googlesource.com/c/1248245
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#596146}
[modify] https://crrev.com/9db6d6fdc4f0d5205d5b72b7902f44ed5dccb7b1/components/discardable_memory/service/discardable_shared_memory_manager.cc
[modify] https://crrev.com/9db6d6fdc4f0d5205d5b72b7902f44ed5dccb7b1/components/discardable_memory/service/discardable_shared_memory_manager.h
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a40b186d6c310a9d0f9fd6a7bc39f768c47f8060

commit a40b186d6c310a9d0f9fd6a7bc39f768c47f8060
Author: Takashi Sakamoto <tasak@google.com>
Date: Thu Oct 04 11:15:38 2018

Remove MemoryCoodinatorClient from content/renderer.

BUG= 888904 

Change-Id: Ia7e7b275a75c4e841b330b6bebae44204dee381a
Reviewed-on: https://chromium-review.googlesource.com/c/1258666
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#596587}
[modify] https://crrev.com/a40b186d6c310a9d0f9fd6a7bc39f768c47f8060/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/a40b186d6c310a9d0f9fd6a7bc39f768c47f8060/content/renderer/render_thread_impl.h
[modify] https://crrev.com/a40b186d6c310a9d0f9fd6a7bc39f768c47f8060/content/renderer/renderer_blink_platform_impl.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/370e46f765d9eaf4932a3ff2d110b396cf6d02f3

commit 370e46f765d9eaf4932a3ff2d110b396cf6d02f3
Author: Takashi Sakamoto <tasak@google.com>
Date: Fri Oct 05 02:51:10 2018

Remove MemoryCoordinatorClient from cc.

BUG= 888904 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I17c89d0ffd9b1dece4bd8779572ff5605e3072fc
Reviewed-on: https://chromium-review.googlesource.com/c/1258784
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#596971}
[modify] https://crrev.com/370e46f765d9eaf4932a3ff2d110b396cf6d02f3/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/370e46f765d9eaf4932a3ff2d110b396cf6d02f3/cc/raster/staging_buffer_pool.cc
[modify] https://crrev.com/370e46f765d9eaf4932a3ff2d110b396cf6d02f3/cc/raster/staging_buffer_pool.h
[modify] https://crrev.com/370e46f765d9eaf4932a3ff2d110b396cf6d02f3/cc/raster/staging_buffer_pool_unittest.cc
[modify] https://crrev.com/370e46f765d9eaf4932a3ff2d110b396cf6d02f3/cc/resources/resource_pool.cc
[modify] https://crrev.com/370e46f765d9eaf4932a3ff2d110b396cf6d02f3/cc/resources/resource_pool.h
[modify] https://crrev.com/370e46f765d9eaf4932a3ff2d110b396cf6d02f3/cc/resources/resource_pool_unittest.cc
[modify] https://crrev.com/370e46f765d9eaf4932a3ff2d110b396cf6d02f3/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/370e46f765d9eaf4932a3ff2d110b396cf6d02f3/cc/tiles/gpu_image_decode_cache.h
[modify] https://crrev.com/370e46f765d9eaf4932a3ff2d110b396cf6d02f3/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/370e46f765d9eaf4932a3ff2d110b396cf6d02f3/cc/tiles/software_image_decode_cache.cc
[modify] https://crrev.com/370e46f765d9eaf4932a3ff2d110b396cf6d02f3/cc/tiles/software_image_decode_cache.h
[modify] https://crrev.com/370e46f765d9eaf4932a3ff2d110b396cf6d02f3/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/370e46f765d9eaf4932a3ff2d110b396cf6d02f3/cc/trees/layer_tree_host_impl.h
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea348290f1df53cbc7a75c0af297399a6ff42826

commit ea348290f1df53cbc7a75c0af297399a6ff42826
Author: Takashi Sakamoto <tasak@google.com>
Date: Tue Oct 09 12:02:16 2018

Remove MemoryCoordinatorClient from MemoryMonitorAndroid.

BUG= 888904 

Change-Id: I72dc02a863f848a3cb9c1d8f4a45aed5a648595c
Reviewed-on: https://chromium-review.googlesource.com/c/1263721
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#597884}
[modify] https://crrev.com/ea348290f1df53cbc7a75c0af297399a6ff42826/content/browser/memory/memory_monitor_android.cc
[modify] https://crrev.com/ea348290f1df53cbc7a75c0af297399a6ff42826/content/browser/memory/memory_monitor_android.h
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/beb96b18d42739814889166ca1c96c4b27000771

commit beb96b18d42739814889166ca1c96c4b27000771
Author: Takashi Sakamoto <tasak@google.com>
Date: Mon Oct 15 04:52:12 2018

Remove MemoryCoordinatorClient from content/browser/dom_storage.

BUG= 888904 

Change-Id: I65002e69cc3dba6acb061bcc4853d10ede1cbe68
Reviewed-on: https://chromium-review.googlesource.com/c/1272958
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#599565}
[modify] https://crrev.com/beb96b18d42739814889166ca1c96c4b27000771/content/browser/dom_storage/dom_storage_context_wrapper.cc
[modify] https://crrev.com/beb96b18d42739814889166ca1c96c4b27000771/content/browser/dom_storage/dom_storage_context_wrapper.h
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c55ad9a5eaeb76b7598963cc30e0ce7fd6a30a9

commit 6c55ad9a5eaeb76b7598963cc30e0ce7fd6a30a9
Author: Takashi Sakamoto <tasak@google.com>
Date: Mon Oct 15 05:25:48 2018

Remove MemoryCoordinatorClient from chrome/browser/chromeos.

BUG= 888904 

Change-Id: I82f7cc310b32a18df79dd46756d685aee03f0276
Reviewed-on: https://chromium-review.googlesource.com/c/1272935
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#599569}
[modify] https://crrev.com/6c55ad9a5eaeb76b7598963cc30e0ce7fd6a30a9/chrome/browser/chromeos/resource_reporter/resource_reporter.cc
[modify] https://crrev.com/6c55ad9a5eaeb76b7598963cc30e0ce7fd6a30a9/chrome/browser/chromeos/resource_reporter/resource_reporter.h
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb074802c50696daf38f0bae08db8a105d4ecaf4

commit bb074802c50696daf38f0bae08db8a105d4ecaf4
Author: Takashi Sakamoto <tasak@google.com>
Date: Mon Oct 15 07:35:27 2018

Remove MemoryCoordinatorClient from content/gpu.

BUG= 888904 

Change-Id: I5e8b2d3d3e2d0975cc5713fdae4b85969308a906
Reviewed-on: https://chromium-review.googlesource.com/c/1264435
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#599582}
[modify] https://crrev.com/bb074802c50696daf38f0bae08db8a105d4ecaf4/content/gpu/gpu_child_thread.cc
[modify] https://crrev.com/bb074802c50696daf38f0bae08db8a105d4ecaf4/content/gpu/gpu_child_thread.h
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c16dc39f9fc27ed48964d6333daa22bf19dd199

commit 5c16dc39f9fc27ed48964d6333daa22bf19dd199
Author: Takashi Sakamoto <tasak@google.com>
Date: Tue Oct 16 03:08:13 2018

Remove "MemoryState" (reported by MemoryCoordinator) from TaskManager.

BUG= 888904 

Change-Id: I70c6f29a95265d3554dd938c00a69a54d1dd5729
Reviewed-on: https://chromium-review.googlesource.com/c/1272420
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#599828}
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/app/generated_resources.grd
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/browser/task_manager/sampling/task_group.cc
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/browser/task_manager/sampling/task_group.h
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/browser/task_manager/sampling/task_manager_impl.cc
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/browser/task_manager/sampling/task_manager_impl.h
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/browser/task_manager/task_manager_browsertest.cc
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/browser/task_manager/task_manager_browsertest_util.cc
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/browser/task_manager/task_manager_browsertest_util.h
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/browser/task_manager/task_manager_interface.h
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/browser/task_manager/task_manager_observer.h
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/browser/task_manager/task_manager_tester.cc
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/browser/task_manager/task_manager_tester.h
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/browser/task_manager/test_task_manager.cc
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/browser/task_manager/test_task_manager.h
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/browser/ui/task_manager/task_manager_columns.cc
[modify] https://crrev.com/5c16dc39f9fc27ed48964d6333daa22bf19dd199/chrome/browser/ui/task_manager/task_manager_table_model.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bc77bbd29ccf8820d20e392fd21b890f008f68a

commit 6bc77bbd29ccf8820d20e392fd21b890f008f68a
Author: Takashi Sakamoto <tasak@google.com>
Date: Tue Oct 16 08:22:33 2018

Remove MemoryCoordinator from content/child

Bug:  888904 
Change-Id: I7f6cda10647b4a14fb6b1de821603f99d1cc8008
Reviewed-on: https://chromium-review.googlesource.com/c/1282085
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#599911}
[delete] https://crrev.com/a5e45fca16338b597af31395106bc22a56f2e0a9/content/browser/memory/memory_coordinator_impl_browsertest.cc
[modify] https://crrev.com/6bc77bbd29ccf8820d20e392fd21b890f008f68a/content/child/BUILD.gn
[modify] https://crrev.com/6bc77bbd29ccf8820d20e392fd21b890f008f68a/content/child/child_thread_impl.cc
[modify] https://crrev.com/6bc77bbd29ccf8820d20e392fd21b890f008f68a/content/child/child_thread_impl.h
[delete] https://crrev.com/a5e45fca16338b597af31395106bc22a56f2e0a9/content/child/memory/child_memory_coordinator_impl.cc
[delete] https://crrev.com/a5e45fca16338b597af31395106bc22a56f2e0a9/content/child/memory/child_memory_coordinator_impl.h
[delete] https://crrev.com/a5e45fca16338b597af31395106bc22a56f2e0a9/content/child/memory/child_memory_coordinator_impl_android.cc
[delete] https://crrev.com/a5e45fca16338b597af31395106bc22a56f2e0a9/content/child/memory/child_memory_coordinator_impl_android.h
[delete] https://crrev.com/a5e45fca16338b597af31395106bc22a56f2e0a9/content/child/memory/child_memory_coordinator_impl_unittest.cc
[modify] https://crrev.com/6bc77bbd29ccf8820d20e392fd21b890f008f68a/content/test/BUILD.gn
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2050591535d673790e3921696c8511adb27fd74e

commit 2050591535d673790e3921696c8511adb27fd74e
Author: Takashi Sakamoto <tasak@google.com>
Date: Thu Oct 18 04:32:54 2018

Remove MemoryCoordinator from BrowserMainLoop

Bug:  888904 
Change-Id: I4531f45b3b5cc6da3deaae06955a30150e762e36
Reviewed-on: https://chromium-review.googlesource.com/c/1286089
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#600658}
[modify] https://crrev.com/2050591535d673790e3921696c8511adb27fd74e/content/browser/browser_main_loop.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bc4d15b11fdc57cfbdb90a7f56f7a065b517d41

commit 8bc4d15b11fdc57cfbdb90a7f56f7a065b517d41
Author: Takashi Sakamoto <tasak@google.com>
Date: Thu Oct 18 06:05:01 2018

Remove MemoryCoordinator from RenderProcessHostImpl

Bug:  888904 
Change-Id: I5be3ea82fed659cb0fc3ddbe13e308eb9e8c1f38
Reviewed-on: https://chromium-review.googlesource.com/c/1286009
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600669}
[modify] https://crrev.com/8bc4d15b11fdc57cfbdb90a7f56f7a065b517d41/content/browser/renderer_host/render_process_host_impl.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afe97a590cc2444daa25c94c2404674b921a909b

commit afe97a590cc2444daa25c94c2404674b921a909b
Author: Takashi Sakamoto <tasak@google.com>
Date: Fri Oct 19 08:13:49 2018

Remove MemoryCoordinatorTestUtils

Bug:  888904 
Change-Id: I1d11d01e7adb51ec15d921c359d0e5171d00cb87
Reviewed-on: https://chromium-review.googlesource.com/c/1286241
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#601079}
[delete] https://crrev.com/9b8749dabce3505abbac682bb4e60ead7534f1b2/content/public/test/memory_coordinator_test_utils.cc
[delete] https://crrev.com/9b8749dabce3505abbac682bb4e60ead7534f1b2/content/public/test/memory_coordinator_test_utils.h
[modify] https://crrev.com/afe97a590cc2444daa25c94c2404674b921a909b/content/test/BUILD.gn
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d50b8f5c289c196cb1ec1b73eb3579e556504360

commit d50b8f5c289c196cb1ec1b73eb3579e556504360
Author: Takashi Sakamoto <tasak@google.com>
Date: Mon Oct 22 06:05:28 2018

Remove MemoryCoordinator from GpuProcessHost

Bug:  888904 
Change-Id: I230b9f4370594029d9ae7ecf222e0b04074d7e35
Reviewed-on: https://chromium-review.googlesource.com/c/1285989
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#601484}
[modify] https://crrev.com/d50b8f5c289c196cb1ec1b73eb3579e556504360/content/browser/gpu/gpu_process_host.cc
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a539a2456973da933aecb5202ee62213b5fa66ea

commit a539a2456973da933aecb5202ee62213b5fa66ea
Author: Takashi Sakamoto <tasak@google.com>
Date: Fri Oct 26 09:52:02 2018

Remove MemoryCoordinatorImpl.

Bug:  888904 
Change-Id: If241906ba3024ff6f4aa6ef7a5ff06dc682a130b
Reviewed-on: https://chromium-review.googlesource.com/c/1293255
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#603045}
[modify] https://crrev.com/a539a2456973da933aecb5202ee62213b5fa66ea/chrome/browser/BUILD.gn
[modify] https://crrev.com/a539a2456973da933aecb5202ee62213b5fa66ea/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/a539a2456973da933aecb5202ee62213b5fa66ea/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/a539a2456973da933aecb5202ee62213b5fa66ea/content/browser/BUILD.gn
[delete] https://crrev.com/35af51e397a46b2adb8a27a305e58b97559208a2/content/browser/memory/memory_condition_observer.cc
[delete] https://crrev.com/35af51e397a46b2adb8a27a305e58b97559208a2/content/browser/memory/memory_condition_observer.h
[delete] https://crrev.com/35af51e397a46b2adb8a27a305e58b97559208a2/content/browser/memory/memory_coordinator_default_policy.cc
[delete] https://crrev.com/35af51e397a46b2adb8a27a305e58b97559208a2/content/browser/memory/memory_coordinator_default_policy.h
[delete] https://crrev.com/35af51e397a46b2adb8a27a305e58b97559208a2/content/browser/memory/memory_coordinator_impl.cc
[delete] https://crrev.com/35af51e397a46b2adb8a27a305e58b97559208a2/content/browser/memory/memory_coordinator_impl.h
[delete] https://crrev.com/35af51e397a46b2adb8a27a305e58b97559208a2/content/browser/memory/memory_coordinator_impl_unittest.cc
[modify] https://crrev.com/a539a2456973da933aecb5202ee62213b5fa66ea/content/common/BUILD.gn
[delete] https://crrev.com/35af51e397a46b2adb8a27a305e58b97559208a2/content/common/child_memory_coordinator.mojom
[delete] https://crrev.com/35af51e397a46b2adb8a27a305e58b97559208a2/content/common/memory_coordinator.mojom
[modify] https://crrev.com/a539a2456973da933aecb5202ee62213b5fa66ea/content/public/browser/BUILD.gn
[modify] https://crrev.com/a539a2456973da933aecb5202ee62213b5fa66ea/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/a539a2456973da933aecb5202ee62213b5fa66ea/content/public/browser/content_browser_client.h
[delete] https://crrev.com/35af51e397a46b2adb8a27a305e58b97559208a2/content/public/browser/memory_coordinator.h
[delete] https://crrev.com/35af51e397a46b2adb8a27a305e58b97559208a2/content/public/browser/memory_coordinator_delegate.h
[modify] https://crrev.com/a539a2456973da933aecb5202ee62213b5fa66ea/content/test/BUILD.gn
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd2a5a0d788cd22ec6aeda84911151b1aef433ad

commit bd2a5a0d788cd22ec6aeda84911151b1aef433ad
Author: Takashi Sakamoto <tasak@google.com>
Date: Tue Oct 30 12:17:35 2018

Remove include memory_coordinator_client_registry.h from gpu/

Bug:  888904 
Change-Id: Ia32cdea2e62828a02f05d555af2635366d077f82
Reviewed-on: https://chromium-review.googlesource.com/c/1304177
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#603866}
[modify] https://crrev.com/bd2a5a0d788cd22ec6aeda84911151b1aef433ad/gpu/command_buffer/service/service_transfer_cache.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09196350e93633199b896837a6d1ad7f2f7d07a3

commit 09196350e93633199b896837a6d1ad7f2f7d07a3
Author: Takashi Sakamoto <tasak@google.com>
Date: Fri Nov 02 11:24:32 2018

Remove MemoryCoordinator from base/

Bug:  888904 
Change-Id: If5ea187530df1f3de0e5f5f9c4b2e3be0e10b397
Reviewed-on: https://chromium-review.googlesource.com/c/1312139
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#604888}
[modify] https://crrev.com/09196350e93633199b896837a6d1ad7f2f7d07a3/base/BUILD.gn
[delete] https://crrev.com/8b97e2b522c5f8d478f9ee4aceb0d6467189f830/base/memory/memory_coordinator_client.cc
[delete] https://crrev.com/8b97e2b522c5f8d478f9ee4aceb0d6467189f830/base/memory/memory_coordinator_client.h
[delete] https://crrev.com/8b97e2b522c5f8d478f9ee4aceb0d6467189f830/base/memory/memory_coordinator_client_registry.cc
[delete] https://crrev.com/8b97e2b522c5f8d478f9ee4aceb0d6467189f830/base/memory/memory_coordinator_client_registry.h
[delete] https://crrev.com/8b97e2b522c5f8d478f9ee4aceb0d6467189f830/base/memory/memory_coordinator_client_registry_unittest.cc
[delete] https://crrev.com/8b97e2b522c5f8d478f9ee4aceb0d6467189f830/base/memory/memory_coordinator_proxy.cc
[delete] https://crrev.com/8b97e2b522c5f8d478f9ee4aceb0d6467189f830/base/memory/memory_coordinator_proxy.h

Comment 20 by tasak@google.com, Nov 5

Status: Fixed (was: Started)

Comment 21 by chrisha@google.com, Nov 5 

Thanks for cleaning this up!
►

Sign in to add a comment