See the link to graphs below.
All graphs for this bug: https://chromeperf.appspot.com/group_report?bug_id=888892 (For debugging:) Original alerts at time of bug-filing: https://chromeperf.appspot.com/group_report?sid=f0119ee497dbb147295e2142d2029b836cf9dfc25e02bd9d51799b09297675ac Bot(s) for this bug's original alert(s): Android Nexus5 Perf Win 7 Nvidia GPU Perf Win 7 Perf mac-10_12_laptop_low_end-perf mac-10_13_laptop_high_end-perf octane - Benchmark documentation link: None
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/17851697640000
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/17851697640000 Turn on full masking with untrusted-code-mitigations by jarin@chromium.org https://chromium.googlesource.com/v8/v8/+/6a6f050e18b90d5b498d85455e598ca68b14238f 6823 → 6324 (-498.9) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: None
A fix patch is submitted https://chromium-review.googlesource.com/c/chromium/src/+/1253341
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/b048c16b4f5f1db0642497bc2926ff1cc00cb484 commit b048c16b4f5f1db0642497bc2926ff1cc00cb484 Author: Jaroslav Sevcik <jarin@chromium.org> Date: Thu Oct 04 10:05:40 2018 [turbofan] Remove branch_load_poisoning flag. The goal is to remove CL to remove the confusing implications for full poisoning. This is an alternative to https://chromium-review.googlesource.com/c/chromium/src/+/1253341 where chrome has to work around our implication system. In the optimizing compiler, we already have a bottleneck for setting mitigation level in src/compiler/pipeline.cc, so it is easy to change back to partial mitigations. Bug: chromium:888892 Change-Id: I01de7ed7bb91e8b06f8f79cc2d90657a0600892a Reviewed-on: https://chromium-review.googlesource.com/c/1252985 Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#56374} [modify] https://crrev.com/b048c16b4f5f1db0642497bc2926ff1cc00cb484/src/builtins/arm/builtins-arm.cc [modify] https://crrev.com/b048c16b4f5f1db0642497bc2926ff1cc00cb484/src/builtins/arm64/builtins-arm64.cc [modify] https://crrev.com/b048c16b4f5f1db0642497bc2926ff1cc00cb484/src/builtins/ia32/builtins-ia32.cc [modify] https://crrev.com/b048c16b4f5f1db0642497bc2926ff1cc00cb484/src/builtins/mips/builtins-mips.cc [modify] https://crrev.com/b048c16b4f5f1db0642497bc2926ff1cc00cb484/src/builtins/mips64/builtins-mips64.cc [modify] https://crrev.com/b048c16b4f5f1db0642497bc2926ff1cc00cb484/src/builtins/x64/builtins-x64.cc [modify] https://crrev.com/b048c16b4f5f1db0642497bc2926ff1cc00cb484/src/compiler/pipeline.cc [modify] https://crrev.com/b048c16b4f5f1db0642497bc2926ff1cc00cb484/src/compiler/simplified-operator.cc [modify] https://crrev.com/b048c16b4f5f1db0642497bc2926ff1cc00cb484/src/flag-definitions.h
Comment 1 by 42576172...@developer.gserviceaccount.com
, Sep 25