New issue
Advanced search Search tips

Issue 888888 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

WebUI Polymer2 isn't running Files app tests.

Project Member Reported by lucmult@chromium.org, Sep 25

Issue description

Current webui_polymer2_browser_tests.filter doesn't include most of the Files app tests.

Files app browser tests has a suffix $TEST_SUITE/FilesAppBrowserTest.Test/$TEST_CASE

Only a few tests are filtering Files app:

-TabIndex/FilesAppBrowserTest.Test/* # disables some known failures.


OpenAudioFiles/*  # Enable some audio file tests.


We probably should add:
*/FilesAppBrowserTest.* to the inclusion list.
 
Owner: lucmult@chromium.org
Status: Assigned (was: Untriaged)
@lucmult: Can you check whether this is still the case? See [1] where */FilesAppBrowserTest.* has already been added to the list.

[1] https://cs.chromium.org/chromium/src/testing/buildbot/filters/webui_polymer2_browser_tests.filter?l=195,247 
Status: Fixed (was: Assigned)
Yeap, it's fixed.

I've just checked one bot:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-chromeos-rel/139070

https://chromium-swarm.appspot.com/task?id=4129f9ae04eb0d10&refresh=10&show_raw=1

Example output of 1 shard:

[368/453] FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutDownloadsVolume (5262 ms)
[369/453] FileDisplay/FilesAppBrowserTest.Test/fileDisplayDriveOffline_DriveFs (5505 ms)
[370/453] FileDisplay/FilesAppBrowserTest.Test/fileDisplayDrive_TabletMode (5768 ms)
[371/453] FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutDriveThenDisable (7357 ms)
[372/453] FileDisplay/FilesAppBrowserTest.Test/fileDisplayMountWithFakeItemSelected (5775 ms)
[373/453] OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenCloseDownloads (6294 ms)
[374/453] OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDrive_DriveFs (6568 ms)
[375/453] OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDrive_DriveFs (5781 ms)
[376/453] OpenAudioFiles/FilesAppBrowserTest.Test/audioNoRepeatModeSingleFileDrive (6303 ms)
[377/453] OpenAudioFiles/FilesAppBrowserTest.Test/audioNoRepeatModeMultipleFileDrive (6297 ms)
[378/453] OpenAudioFiles/FilesAppBrowserTest.Test/audioOpenDrive (10763 ms)
[379/453] CreateNewFolder/FilesAppBrowserTest.Test/selectCreateFolderDownloads (5517 ms)
[380/453] KeyboardOperations/FilesAppBrowserTest.Test/keyboardDeleteDownloads (5772 ms)
[381/453] KeyboardOperations/FilesAppBrowserTest.Test/keyboardDeleteDrive_DriveFs (6044 ms)
[382/453] CreateNewFolder/FilesAppBrowserTest.Test/createFolderNestedDownloads (6305 ms)
[383/453] KeyboardOperations/FilesAppBrowserTest.Test/keyboardCopyDrive_DriveFs (4979 ms)
[384/453] KeyboardOperations/FilesAppBrowserTest.Test/renameNewFolderDrive_DriveFs (5513 ms)
[385/453] KeyboardOperations/FilesAppBrowserTest.Test/renameFileDownloads_GuestMode (6043 ms)
[386/453] KeyboardOperations/FilesAppBrowserTest.Test/renameFileDrive (6033 ms)
[387/453] ContextMenu/FilesAppBrowserTest.Test/checkDeleteDisabledForReadOnlyFolder (3943 ms)
[388/453] ContextMenu/FilesAppBrowserTest.Test/checkRenameEnabledForReadWriteFile (5246 ms)
[389/453] ContextMenu/FilesAppBrowserTest.Test/checkCutDisabledForReadOnlyDocument (5505 ms)
[390/453] ContextMenu/FilesAppBrowserTest.Test/checkPasteIntoFolderEnabledForReadWriteFolder (5247 ms)
[391/453] ContextMenu/FilesAppBrowserTest.Test/checkContextMenusForInputElements (5246 ms)
[392/453] ContextMenu/FilesAppBrowserTest.Test/checkContextMenuForTeamDriveRoot (5505 ms)
[393/453] ContextMenu/FilesAppBrowserTest.Test/checkNewFolderEnabledInsideReadWriteFolder (5775 ms)
[394/453] ContextMenu2/FilesAppBrowserTest.Test/checkDeleteEnabledForReadWriteFile_DriveFs (5519 ms)
[395/453] ContextMenu2/FilesAppBrowserTest.Test/checkRenameDisabledForReadOnlyFile_DriveFs (4990 ms)
[396/453] ContextMenu2/FilesAppBrowserTest.Test/checkCopyEnabledForReadWriteFile_DriveFs (5243 ms)
[397/453] ContextMenu2/FilesAppBrowserTest.Test/checkShareEnabledForReadWriteFile_DriveFs (5766 ms)
[398/453] ContextMenu2/FilesAppBrowserTest.Test/checkShareEnabledForReadOnlyFolder_DriveFs (5787 ms)
[399/453] ContextMenu2/FilesAppBrowserTest.Test/checkPasteIntoFolderDisabledForReadOnlyFolder_DriveFs (5542 ms)
[400/453] ContextMenu2/FilesAppBrowserTest.Test/checkNewFolderEnabledInsideReadWriteFolder_DriveFs (5774 ms)
[401/453] ContextMenu2/FilesAppBrowserTest.Test/checkCopyEnabledForReadWriteFolderInTree_DriveFs (5506 ms)
[402/453] Delete/FilesAppBrowserTest.Test/deleteEntryWithToolbar_GuestMode (6036 ms)
[403/453] QuickView/FilesAppBrowserTest.Test/openQuickViewScrollHtml (7614 ms)
[404/453] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCopyWithContextMenu (6030 ms)
[405/453] QuickView/FilesAppBrowserTest.Test/openQuickViewMtp (6559 ms)
[406/453] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCutWithKeyboard (6037 ms)
[407/453] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameUpdateChildrenBreadcrumbs (6039 ms)
[408/453] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameWithKeyboard_GuestMode (5243 ms)
[409/453] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameWithKeyboard (5772 ms)
[410/453] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameToEmptyString (5772 ms)
[411/453] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirRenameToExisting_GuestMode (4991 ms)
[412/453] DriveSpecific/FilesAppBrowserTest.Test/driveOpenSidebarSharedWithMe (5505 ms)
[413/453] DriveSpecific/FilesAppBrowserTest.Test/driveAutoCompleteQuery (5509 ms)
[414/453] DirectoryTreeContextMenu/FilesAppBrowserTest.Test/dirCreateWithKeyboard (6307 ms)
[415/453] DriveSpecific/FilesAppBrowserTest.Test/drivePinFileMobileNetwork (5253 ms)
[416/453] DriveSpecific/FilesAppBrowserTest.Test/drivePinFileMobileNetwork_DriveFs (5508 ms)
[417/453] DriveSpecific/FilesAppBrowserTest.Test/drivePressCtrlAFromSearch (5508 ms)
[418/453] Transfer/FilesAppBrowserTest.Test/transferFromDownloadsToDrive_DriveFs (6298 ms)
[419/453] Transfer/FilesAppBrowserTest.Test/transferFromSharedToDrive_DriveFs (6299 ms)
[420/453] Transfer/FilesAppBrowserTest.Test/transferFromTeamDriveToDownloads_DriveFs (6039 ms)
[421/453] Transfer/FilesAppBrowserTest.Test/transferFromDownloadsToTeamDrive (6307 ms)
[422/453] RestorePrefs/FilesAppBrowserTest.Test/restoreSortColumn (7885 ms)
[423/453] RestoreGeometry/FilesAppBrowserTest.Test/restoreGeometry_GuestMode (7353 ms)
[424/453] ShareAndManageDialog/FilesAppBrowserTest.Test/shareFileDrive (6304 ms)
[425/453] ShareAndManageDialog/FilesAppBrowserTest.Test/shareDirectoryDrive (5804 ms)
[426/453] ShareAndManageDialog/FilesAppBrowserTest.Test/manageHostedFileDrive (6044 ms)
[427/453] Traverse/FilesAppBrowserTest.Test/traverseDownloads (6031 ms)
[428/453] Traverse/FilesAppBrowserTest.Test/traverseDrive (5772 ms)
[429/453] Traverse/FilesAppBrowserTest.Test/traverseDrive_DriveFs (5778 ms)
[430/453] Tasks/FilesAppBrowserTest.Test/executeDefaultTaskDownloads (5506 ms)
[431/453] Tasks/FilesAppBrowserTest.Test/defaultTaskDialogDownloads_GuestMode (6296 ms)
[432/453] TabIndex/FilesAppBrowserTest.Test/tabindexSearchBoxFocus (4991 ms)
[433/453] TabIndex/FilesAppBrowserTest.Test/tabindexOpenDialogDownloads (5243 ms)
[434/453] FileDialog/FilesAppBrowserTest.Test/openFileDialogUnload (4457 ms)
[435/453] FolderShortcuts/FilesAppBrowserTest.Test/addRemoveFolderShortcuts (8399 ms)
[436/453] FileDialog/FilesAppBrowserTest.Test/openFileDialogCancelDownloads (4993 ms)
[437/453] FileDialog/FilesAppBrowserTest.Test/openFileDialogDrive (6034 ms)
[438/453] FileDialog/FilesAppBrowserTest.Test/openFileDialogCancelDrive (5776 ms)
[439/453] FileDialog/FilesAppBrowserTest.Test/openFileDialogDrive_DriveFs (6307 ms)
[440/453] FileDialog/FilesAppBrowserTest.Test/openFileDialogEscapeDrive (4484 ms)
[441/453] GridView/FilesAppBrowserTest.Test/showGridViewDrive (5244 ms)
[442/453] CopyBetweenWindows/FilesAppBrowserTest.Test/copyBetweenWindowsLocalToDrive_DriveFs (7366 ms)
[443/453] CopyBetweenWindows/FilesAppBrowserTest.Test/copyBetweenWindowsDriveToUsb (7889 ms)
[444/453] CopyBetweenWindows/FilesAppBrowserTest.Test/copyBetweenWindowsUsbToLocal (8127 ms)
[445/453] GearMenu/FilesAppBrowserTest.Test/showToggleHiddenAndroidFoldersGearMenuItemsInMyFiles (5266 ms)
[446/453] Recents/FilesAppBrowserTest.Test/recentsDrive (5517 ms)
[447/453] Recents/FilesAppBrowserTest.Test/recentsDownloadsAndDrive (5253 ms)
[448/453] Recents/FilesAppBrowserTest.Test/recentsDownloadsAndDriveWithOverlap (5250 ms)
[449/453] Metadata/FilesAppBrowserTest.Test/metadataDownloads (5512 ms)
[450/453] Metadata/FilesAppBrowserTest.Test/metadataDrive (5786 ms)
[451/453] Metadata/FilesAppBrowserTest.Test/metadataLargeDrive (5512 ms)
[452/453] Metadata/FilesAppBrowserTest.Test/metadataLargeDrive_DriveFs (5245 ms)
[453/453] MultiProfileFilesAppBrowserTest.BasicDrive (3938 ms)
SUCCESS: all tests passed.
Status: Verified (was: Fixed)

Sign in to add a comment