Flaky test: DumpAccessibilityEventsTest.AccessibilityEventsCaretMove Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=402767a518cd6410 Test output log: https://ci.chromium.org/buildbot/chromium.win/Win10%20Tests%20x64/27833 Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/Ib9ac49e60c218169e8108ef83b000fcaaf176570 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy3wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKoAWNocm9taXVtLndpbi9XaW4xMCBUZXN0cyB4NjQvMjc4MzMvbmV0d29ya19zZXJ2aWNlX2NvbnRlbnRfYnJvd3NlcnRlc3RzIG9uIFdpbmRvd3MtMTAtMTUwNjMvUkhWdGNFRmpZMlZ6YzJsaWFXeHBkSGxGZG1WdWRITlVaWE4wTGtGalkyVnpjMmxpYVd4cGRIbEZkbVZ1ZEhORFlYSmxkRTF2ZG1VPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20DumpAccessibilityEventsTest.AccessibilityEventsCaretMove&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy3wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKoAWNocm9taXVtLndpbi9XaW4xMCBUZXN0cyB4NjQvMjc4MzMvbmV0d29ya19zZXJ2aWNlX2NvbnRlbnRfYnJvd3NlcnRlc3RzIG9uIFdpbmRvd3MtMTAtMTUwNjMvUkhWdGNFRmpZMlZ6YzJsaWFXeHBkSGxGZG1WdWRITlVaWE4wTGtGalkyVnpjMmxpYVd4cGRIbEZkbVZ1ZEhORFlYSmxkRTF2ZG1VPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
Findit created a revert, but couldn't land it due to a conflict. I'm resolving the conflict and will land it.
Revert is going through as https://chromium-review.googlesource.com/c/chromium/src/+/1242903.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/970fa0939bbfb466ddd4f5bc5c54723a96756213 commit 970fa0939bbfb466ddd4f5bc5c54723a96756213 Author: Colin Blundell <blundell@chromium.org> Date: Tue Sep 25 10:14:34 2018 Revert "Only fire caret location change if it actually changes" This reverts commit 12fb3159938f0aa4153b646298a7248e178df8c3. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 593533 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMTJmYjMxNTk5MzhmMGFhNDE1M2I2NDYyOThhNzI0OGUxNzhkZjhjMww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win10%20Tests%20x64/27833 Sample Failed Step: network_service_content_browsertests on Windows-10-15063 Sample Flaky Test: DumpAccessibilityEventsTest.AccessibilityEventsCaretMove Original change's description: > Only fire caret location change if it actually changes > > Also add tests for caret events. > > Bug: 877487 > Change-Id: Ib9ac49e60c218169e8108ef83b000fcaaf176570 > Reviewed-on: https://chromium-review.googlesource.com/1189184 > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593533} No-Presubmit: true Bug: 877487 , 888877 Change-Id: Ic6fe9dc3c454c8a5602e0ac12671e7061f9939fe Reviewed-on: https://chromium-review.googlesource.com/1242903 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#593883} [modify] https://crrev.com/970fa0939bbfb466ddd4f5bc5c54723a96756213/content/browser/accessibility/accessibility_event_recorder_win.cc [modify] https://crrev.com/970fa0939bbfb466ddd4f5bc5c54723a96756213/content/browser/accessibility/dump_accessibility_browsertest_base.cc [modify] https://crrev.com/970fa0939bbfb466ddd4f5bc5c54723a96756213/content/browser/accessibility/dump_accessibility_browsertest_base.h [modify] https://crrev.com/970fa0939bbfb466ddd4f5bc5c54723a96756213/content/browser/accessibility/dump_accessibility_events_browsertest.cc [modify] https://crrev.com/970fa0939bbfb466ddd4f5bc5c54723a96756213/content/browser/accessibility/dump_accessibility_tree_browsertest.cc [modify] https://crrev.com/970fa0939bbfb466ddd4f5bc5c54723a96756213/content/test/data/accessibility/event/aria-combo-box-focus.html [delete] https://crrev.com/dd97891ac088be34a2d7f60e068a15d7a0ff2435/content/test/data/accessibility/event/caret-move-expected-win.txt [delete] https://crrev.com/dd97891ac088be34a2d7f60e068a15d7a0ff2435/content/test/data/accessibility/event/caret-move.html [modify] https://crrev.com/970fa0939bbfb466ddd4f5bc5c54723a96756213/content/test/data/accessibility/readme.md [modify] https://crrev.com/970fa0939bbfb466ddd4f5bc5c54723a96756213/ui/accessibility/ax_node_data.cc [modify] https://crrev.com/970fa0939bbfb466ddd4f5bc5c54723a96756213/ui/accessibility/ax_node_data.h [modify] https://crrev.com/970fa0939bbfb466ddd4f5bc5c54723a96756213/ui/accessibility/platform/ax_system_caret_win.cc [modify] https://crrev.com/970fa0939bbfb466ddd4f5bc5c54723a96756213/ui/accessibility/platform/ax_system_caret_win.h [modify] https://crrev.com/970fa0939bbfb466ddd4f5bc5c54723a96756213/ui/views/win/hwnd_message_handler.cc
Comment 1 by blundell@chromium.org
, Sep 25Status: Started (was: Untriaged)