New issue
Advanced search Search tips

Issue 888874 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Slot element's wrappers getting collected

Project Member Reported by hayato@chromium.org, Sep 25

Issue description

Report from rniwa@apple.com

----

Hi,

It looks like both WebKit and Blink have a problem where we end up collecting JS wrappers of slot elements enqueued for a slotchange event

You can see that this test case fails on both Safari & Chrome where it passes always on Firefox:
https://bug-167652-attachments.webkit.org/attachment.cgi?id=350479
(You may need to reload multiple times / tweak the numbers in the test to reproduce the issue on Chrome)

I was under the impression that oilpan solved all these wrapper lifecycle related issues but perhaps you still manually keep JS wrappers alive?

If so, you probably want to make sure you don’t have the same bug for custom element reaction queues as we did in WebKit:
https://trac.webkit.org/browser/webkit/trunk/LayoutTests/fast/custom-elements/custom-elements-reaction-queue-retains-js-wrapper.html?rev=236376
Again, you might need to tweak the test to induce the issue in Chrome if one exists.



 
Cc: keishi@chromium.org
cc: yukishiino@ (binding), keishi@ (oilpan)

Could you have a chance to take a look?
Status: Available (was: Untriaged)
The issue can be reproduced easily: https://bug-167652-attachments.webkit.org/attachment.cgi?id=350479
Labels: -Pri-2 Pri-3
I chatted with yukishiino@.

Per the discussion, this issue will be resolved once unified GC is enabled in Blink.

Given that unified GC will be shipped sooner or later, we won't take any action on this issue.
We might close this as WONTFIX after unified GC is shipped.

Sign in to add a comment