Size Trybot should prevent adding kConstants to .data |
|||
Issue descriptionFor prior context: bug 747064 Steps: 1. Add to supersize's canned_queries.py a query for: size_info.symbols.WhereFullNameMatches(r'\bk[A-Z]').WhereInSection('d') 2. Fail trybot if diff contains any of these as symbol adds
,
Jan 15
,
Today
(13 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50395e42f179d36331b2b160031d8c6fb27790e0 commit 50395e42f179d36331b2b160031d8c6fb27790e0 Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Jan 22 19:12:28 2019 android-binary-size trybot: Add check for mutable constants Read-only symbols are more memory-efficient than mutable ones. There have been a couple of past audits to fix these up, but catching them with a trybot is much nicer! TBR=agrieve # Trivial adding of "const" Bug: 888863 Change-Id: Ica73a420fe6099d63e094274d71129a9cf5c85ef Reviewed-on: https://chromium-review.googlesource.com/c/1423669 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#624862} [modify] https://crrev.com/50395e42f179d36331b2b160031d8c6fb27790e0/chrome/app/android/chrome_jni_onload.cc [modify] https://crrev.com/50395e42f179d36331b2b160031d8c6fb27790e0/components/safe_browsing/ping_manager.cc [modify] https://crrev.com/50395e42f179d36331b2b160031d8c6fb27790e0/components/search_engines/template_url_fetcher.cc [modify] https://crrev.com/50395e42f179d36331b2b160031d8c6fb27790e0/tools/binary_size/libsupersize/models.py [modify] https://crrev.com/50395e42f179d36331b2b160031d8c6fb27790e0/tools/binary_size/trybot_commit_size_checker.py
,
Today
(4 hours ago)
|
|||
►
Sign in to add a comment |
|||
Comment 1 by agrieve@chromium.org
, Oct 3Blocking: -702625