New issue
Advanced search Search tips

Issue 888855 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

SuperSize: Do not include debug sections in ELF section_sizes

Project Member Reported by agrieve@chromium.org, Sep 25

Issue description

During archive, we include section sizes as listed in the linker map file, but this includes sections that get stripped.
* Including the stripped sections adds noise, and inflates the size of symtab
* We should instead use readelf against the stripped binary.
  * We already collect this, so the change would just be to use it instead of the map file data.

Also: We should delete unpacked relocation sizes:
https://cs.chromium.org/chromium/src/tools/binary_size/libsupersize/archive.py?rcl=afeccd76584c3f1512453836484a1a88b2b9f12b&l=1049

This code hasn't worked since we switched to lld (the linker directly packs relocations). 
We should just delete the "(unpacked)" metrics.

 
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Comment 2 by agrieve@chromium.org, Yesterday (41 hours ago)

Labels: binary_size_team_q1_2019

Sign in to add a comment