In the website "Stats for nerds" graphs, it would be useful to see the frame quantizer values, to show how the frame quality varies over time.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e495d5a4e192487eaaaf53e1d52f4957701f687d commit e495d5a4e192487eaaaf53e1d52f4957701f687d Author: Lambros Lambrou <lambroslambrou@chromium.org> Date: Fri Sep 28 00:41:00 2018 [remoting WebRTC] Add quantizer to per-frame statistics. This adds the VP8/9 frame quantizer to the stats for each frame. This will enable the website to show a graph of these values over time. This also adds new FrameStats unittests, and fixes a capturer_id initialization bug discovered by the unittest. Bug: 888833 Change-Id: I2c48f9c024a0e64a6a5756a3371717d3491a8474 Reviewed-on: https://chromium-review.googlesource.com/1242398 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#594934} [modify] https://crrev.com/e495d5a4e192487eaaaf53e1d52f4957701f687d/remoting/proto/video_stats.proto [modify] https://crrev.com/e495d5a4e192487eaaaf53e1d52f4957701f687d/remoting/protocol/BUILD.gn [modify] https://crrev.com/e495d5a4e192487eaaaf53e1d52f4957701f687d/remoting/protocol/frame_stats.cc [modify] https://crrev.com/e495d5a4e192487eaaaf53e1d52f4957701f687d/remoting/protocol/frame_stats.h [add] https://crrev.com/e495d5a4e192487eaaaf53e1d52f4957701f687d/remoting/protocol/frame_stats_unittest.cc [modify] https://crrev.com/e495d5a4e192487eaaaf53e1d52f4957701f687d/remoting/protocol/webrtc_video_stream.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56b9d6b002b60414b04c15e533dbdadb1f57d97f commit 56b9d6b002b60414b04c15e533dbdadb1f57d97f Author: Lambros Lambrou <lambroslambrou@chromium.org> Date: Fri Oct 05 19:49:06 2018 Change frame 'quantizer' to 'quality' in video_stats.proto. In the per-frame statistics, instead of sending raw frame quantizer values from the VPX encoder (from 0-63), this sends a simple measure of frame quality, from 0-100, with 100 being a lossless frame. Bug: 888833 Change-Id: I9e869f2f302232d10311719a209c79e2492579b7 Reviewed-on: https://chromium-review.googlesource.com/c/1263560 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#597252} [modify] https://crrev.com/56b9d6b002b60414b04c15e533dbdadb1f57d97f/remoting/proto/video_stats.proto [modify] https://crrev.com/56b9d6b002b60414b04c15e533dbdadb1f57d97f/remoting/protocol/frame_stats.cc [modify] https://crrev.com/56b9d6b002b60414b04c15e533dbdadb1f57d97f/remoting/protocol/frame_stats.h [modify] https://crrev.com/56b9d6b002b60414b04c15e533dbdadb1f57d97f/remoting/protocol/frame_stats_unittest.cc [modify] https://crrev.com/56b9d6b002b60414b04c15e533dbdadb1f57d97f/remoting/protocol/webrtc_video_stream.cc
Comment 1 by lambroslambrou@chromium.org
, Sep 25