New issue
Advanced search Search tips

Issue 888825 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 26
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

DCHECK failure in byte_data_->size() % ByteData::kSkippableFunctionDataSize == ByteData::kPlacehol

Project Member Reported by ClusterFuzz, Sep 25

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4886486141632512

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  byte_data_->size() % ByteData::kSkippableFunctionDataSize == ByteData::kPlacehol
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=56170:56171

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4886486141632512

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 25

Labels: Test-Predator-Auto-Owner
Owner: verwa...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/dc2e7786a1998f99101021b17e9688825b3c23ce ([parser] Only clear tempzone if we actually parse in it).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Labels: Security_Impact-Head
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 25

Labels: Target-71 M-71
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 25

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 25

Labels: Pri-1
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/55ecf51e33cad18f1706ff32617e78e360327654

commit 55ecf51e33cad18f1706ff32617e78e360327654
Author: Toon Verwaest <verwaest@chromium.org>
Date: Tue Sep 25 15:28:18 2018

[parser] Don't resolve preparser variables for arrow functions

I moved AnalyzePartially from ParseFunctionLiteral to SkipFunction, but arrow
functions only used the ResetAfterPreparsing part.

Bug:  chromium:888825 

Change-Id: I08de99af128b28031df6ed86a725e4dc918078f8
Reviewed-on: https://chromium-review.googlesource.com/1243383
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56218}
[modify] https://crrev.com/55ecf51e33cad18f1706ff32617e78e360327654/src/ast/scopes.cc
[modify] https://crrev.com/55ecf51e33cad18f1706ff32617e78e360327654/src/parsing/parser-base.h
[add] https://crrev.com/55ecf51e33cad18f1706ff32617e78e360327654/test/mjsunit/regress/regress-crbug-888825.js

Project Member

Comment 7 by ClusterFuzz, Sep 26

ClusterFuzz has detected this issue as fixed in range 56217:56218.

Detailed report: https://clusterfuzz.com/testcase?key=4886486141632512

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  byte_data_->size() % ByteData::kSkippableFunctionDataSize == ByteData::kPlacehol
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=56170:56171
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=56217:56218

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4886486141632512

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Sep 26

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4886486141632512 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 26

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 11 by sheriffbot@chromium.org, Jan 2

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment