New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 888819 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Presubmit crash with locally deleted file

Project Member Reported by pkasting@chromium.org, Sep 25

Issue description

Trying to upload https://chromium-review.googlesource.com/c/chromium/src/+/1241813 gives me a presubmit error because it's trying to run presubmit checks on a locally-deleted file:

$ git cl upload
Running presubmit upload checks ...
Traceback (most recent call last):
  File "C:\src\depot_tools\metrics.py", line 225, in print_notice_and_exit
    yield
  File "C:\src\depot_tools\git_cl.py", line 6161, in <module>
    sys.exit(main(sys.argv[1:]))
  File "C:\src\depot_tools\git_cl.py", line 6143, in main
    return dispatcher.execute(OptionParser(), argv)
  File "C:\src\depot_tools\subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "C:\src\depot_tools\metrics.py", line 210, in _inner
    return self._collect_metrics(func, command_name, *args, **kwargs)
  File "C:\src\depot_tools\metrics.py", line 167, in _collect_metrics
    result = func(*args, **kwargs)
  File "C:\src\depot_tools\git_cl.py", line 5137, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "C:\src\depot_tools\git_cl.py", line 1603, in CMDUpload
    change=change, parallel=options.parallel)
  File "C:\src\depot_tools\git_cl.py", line 1537, in RunHook
    parallel=parallel)
  File "C:\src\depot_tools\presubmit_support.py", line 1547, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "C:\src\depot_tools\presubmit_support.py", line 1454, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 3430, in CheckChangeOnUpload
  File "<string>", line 3013, in _CommonChecks
  File "<string>", line 901, in _CheckNoDISABLETypoInTests
  File "C:\src\depot_tools\presubmit_support.py", line 719, in ReadFile
    return gclient_utils.FileRead(file_item, mode)
  File "C:\src\depot_tools\gclient_utils.py", line 139, in FileRead
    with open(filename, mode=mode) as f:
IOError: [Errno 2] No such file or directory: 'C:\\src\\trunk\\src\\chrome\\browser\\ui\\views\\tabs\\alert_indicator_button_unittest.cc'

(Not really sure why the callstack has no filename for frames near the bottom)

For now I have to disable presubmit on this to get it to upload.
 
Cc: sadrul@chromium.org dpranke@google.com
 Issue 888881  has been merged into this issue.
Cc: moh...@chromium.org
Cc: battre@chromium.org
Owner: katie@chromium.org
Status: Fixed (was: Untriaged)
Introduced in https://chromium.googlesource.com/chromium/src/+/033531055256a55715e08b9a999099f20051c8a1 and appears to have been fixed by https://chromium.googlesource.com/chromium/src/+/f13948e30bab4ed44a3454064d28d91f9300f252

Sign in to add a comment