New issue
Advanced search Search tips

Issue 888817 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Remove Heavy Page Capping InfoBar when the network has no activity

Project Member Reported by ryansturm@chromium.org, Sep 25

Issue description

The Heavy Page Capping InfoBar should be removed if the page has no network activity after 8 seconds, and it should not be shown again after it is dismissed in this manner.
 
Labels: OS-Android
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02995c148a49e39b5485820f81d856f6b47434f5

commit 02995c148a49e39b5485820f81d856f6b47434f5
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Thu Sep 27 19:59:51 2018

Dismiss the heavy page capping UI when network has stopped

This CL adds logic to dismiss the heavy page capping InfoBar after 8
seconds of no requests being finished on the page. The actual time is
field trial configurable. This also adds a browser test to check this
behavior.

Bug:  888817 
Change-Id: I7332918b4590f2f8cd70db365af8dce60f26956c
Reviewed-on: https://chromium-review.googlesource.com/1242173
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594831}
[modify] https://crrev.com/02995c148a49e39b5485820f81d856f6b47434f5/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_browsertest.cc
[modify] https://crrev.com/02995c148a49e39b5485820f81d856f6b47434f5/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_infobar_delegate.cc
[modify] https://crrev.com/02995c148a49e39b5485820f81d856f6b47434f5/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_infobar_delegate.h
[modify] https://crrev.com/02995c148a49e39b5485820f81d856f6b47434f5/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_infobar_delegate_unittest.cc
[modify] https://crrev.com/02995c148a49e39b5485820f81d856f6b47434f5/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/02995c148a49e39b5485820f81d856f6b47434f5/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.cc
[modify] https://crrev.com/02995c148a49e39b5485820f81d856f6b47434f5/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer.h
[modify] https://crrev.com/02995c148a49e39b5485820f81d856f6b47434f5/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/02995c148a49e39b5485820f81d856f6b47434f5/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment