Flakiness testing fails on recent Mac run of worklet-animation-responsive-to-zoom.html |
||||
Issue descriptionPage URL: https://findit-for-me.appspot.com/waterfall/flake Description: Can't run flake testing on bug filed by FindIt. Neither can FindIt seemingly, no culprit has been identified. Bug filed by FindIt: crbug.com/888210 Flake occurrence page: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyeAsSBUZsYWtlIm1jaHJvbWl1bUB3ZWJraXRfbGF5b3V0X3Rlc3RzQHZpcnR1YWwvdGhyZWFkZWQvZmFzdC9hbmltYXRpb253b3JrbGV0L3dvcmtsZXQtYW5pbWF0aW9uLXJlc3BvbnNpdmUtdG8tem9vbS5odG1sDA Doesn't look like the flakiness testing ran, so I'm trying to run it manually: Error: Flake analysis is not supported for "webkit_layout_tests on Intel GPU on Mac (with patch) on Mac-10.12.6/virtual/threaded/fast/animationworklet/worklet-animation-responsive-to-zoom.html". Either the test type is not supported or the test is not swarmed yet. Attaching screenshot of parameters used. I think they look reasonable.
,
Sep 25
chanli@, liaoyuke@: would you mind prioritizing this? Since we file a bug, it is expected that we kick off a flake analysis too.
,
Sep 25
This isn't a sheriff bug.
,
Sep 25
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/e103a6744e0d6380e29650acf3ee3e7cbaf071a8 commit e103a6744e0d6380e29650acf3ee3e7cbaf071a8 Author: Chan <chanli@chromium.org> Date: Mon Oct 01 18:53:04 2018 [Findit] Fix a bug when caching step_metadata only keyed by step_name. A regression was introduced during refactoring: the key generator which was used for caching canonical_step_name was reused for caching the whole step_metadata. And that caused issues when Findit need step_metadata for a specific step in a specific build. Bug: 888809 Change-Id: I01937813df0a692ffc0b3051030b786cd9e18391 Reviewed-on: https://chromium-review.googlesource.com/c/1244218 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#17973} [modify] https://crrev.com/e103a6744e0d6380e29650acf3ee3e7cbaf071a8/appengine/findit/services/step_util.py [modify] https://crrev.com/e103a6744e0d6380e29650acf3ee3e7cbaf071a8/appengine/findit/services/test/step_util_test.py |
||||
►
Sign in to add a comment |
||||
Comment 1 by pbos@chromium.org
, Sep 24