New issue
Advanced search Search tips

Issue 888799 link

Starred by 1 user
Status: Verified
Owner:
fbeaufort@chromium.org
Closed: Sep 25
Cc:
jochen@chromium.org
beaufort...@gmail.com
timvolod...@chromium.org
mlamouri@chromium.org
aluo@chromium.org
satyavat...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Blink interfaces EnterPictureInPictureEvent not exposed for WebView

Project Member Reported by sbash...@chromium.org, Sep 24 

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934467043563649392/+/steps/system_webview_shell_layout_test_apk/0/logs/org.chromium.webview_shell.test.WebViewLayoutTest_testWebViewIncludedStableInterfaces/0

-----------------------------------------------------------------------
java.lang.AssertionError: Android WebView is missing the following declared Blink interfaces: interface EnterPictureInPictureEvent : Event
. Interfaces which are intentionally not exposed in WebView need to be added to not-webview-exposed.txt
	at org.junit.Assert.fail(Assert.java:88)
	at org.chromium.webview_shell.test.WebViewLayoutTest.testWebViewIncludedStableInterfaces(WebViewLayoutTest.java:239)
	at java.lang.reflect.Method.invoke(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:372)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:237)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:48)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:220)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)
Searching for native crashes in: /b/s/w/ir/tmp/t/tmpj0blEG
Unknown Android release, consider passing --packed-lib.
Reading Android symbols from: /b/s/w/ir/cache/builder/src
Searching for Chrome symbols from within: /b/s/w/ir/cache/builder/src/out/Debug/lib.unstripped:/b/s/w/ir/cache/builder/src/out/Debug
java.lang.AssertionError: Android WebView is missing the following declared Blink interfaces: interface EnterPictureInPictureEvent : Event
. Interfaces which are intentionally not exposed in WebView need to be added to not-webview-exposed.txt
	at org.junit.Assert.fail(Assert.java:88)
	at org.chromium.webview_shell.test.WebViewLayoutTest.testWebViewIncludedStableInterfaces(WebViewLayoutTest.java:239)
	at java.lang.reflect.Method.invoke(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:372)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:237)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:48)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:220)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)
Searching for native crashes in: /b/s/w/ir/tmp/t/tmpwDZB64
Unknown Android release, consider passing --packed-lib.
Reading Android symbols from: /b/s/w/ir/cache/builder/src
Searching for Chrome symbols from within: /b/s/w/ir/cache/builder/src/out/Debug/lib.unstripped:/b/s/w/ir/cache/builder/src/out/Debug
java.lang.AssertionError: Android WebView is missing the following declared Blink interfaces: interface EnterPictureInPictureEvent : Event
. Interfaces which are intentionally not exposed in WebView need to be added to not-webview-exposed.txt
	at org.junit.Assert.fail(Assert.java:88)
	at org.chromium.webview_shell.test.WebViewLayoutTest.testWebViewIncludedStableInterfaces(WebViewLayoutTest.java:239)
	at java.lang.reflect.Method.invoke(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:372)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:237)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:48)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:220)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)

Comment 1 by aluo@chromium.org, Sep 25

Cc: beaufort...@gmail.com timvolod...@chromium.org mlamouri@chromium.org
Components: Blink>Media>PictureInPicture
Labels: -Restrict-View-Google ReleaseBlock-Stable
Owner: jochen@chromium.org
Summary: Blink interfaces EnterPictureInPictureEvent not exposed for WebView (was: CTS L/M/N] system_webview_shell_layout_test_apk failed org.chromium.webview_shell.test.WebViewLayoutTest#testWebViewIncludedStableInterfaces )
Due to https://chromium-review.googlesource.com/1228122.

Please update https://chromium.googlesource.com/chromium/src/+/master/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt if it's not intended to be available for webview, or expose it for webview if it should be available in webview.

Comment 2 by ntfschr@chromium.org, Sep 25

Status: Assigned (was: Available)
Available -> assigned

Comment 3 by fbeaufort@chromium.org, Sep 25

Cc: jochen@chromium.org
Owner: fbeaufort@chromium.org

Comment 4 by fbeaufort@chromium.org, Sep 25

Status: Started (was: Assigned)
WIP at https://chromium-review.googlesource.com/c/chromium/src/+/1241875
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cde4ece69e1be0b92ff4f7bb87af6a1bd9f1af4

commit 8cde4ece69e1be0b92ff4f7bb87af6a1bd9f1af4
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Tue Sep 25 09:29:28 2018

Don't expose EnterPictureInPictureEvent for Android WebView.

Picture-in-Picture API is disabled in Android WebView as there is no UI
implemented.

Bug:  888799 , 888512
Change-Id: I8d87e4b659f21d78bc19eb09a1f445a1ad4f2101
Reviewed-on: https://chromium-review.googlesource.com/1241875
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#593877}
[modify] https://crrev.com/8cde4ece69e1be0b92ff4f7bb87af6a1bd9f1af4/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt

Comment 6 by fbeaufort@chromium.org, Sep 25

Status: Fixed (was: Started)

Comment 7 by sbash...@chromium.org, Sep 26

Status: Verified (was: Fixed)
Verified CTS tests and failures not observed on latest CTS run.
►

Sign in to add a comment