New issue
Advanced search Search tips

Issue 888798 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

runtime.onInstalled doesn't fire for SW based extension

Project Member Reported by lazyboy@chromium.org, Sep 24

Issue description

I'm trying to run sample SW based extension and noticed that runtime.onInstalled event doesn't fire upon unpacked load. I mistakenly thought that it works because of https://cs.chromium.org/chromium/src/chrome/test/data/extensions/api_test/service_worker/events_to_stopped_extension/background.js?rcl=354be2de4169cce231487a7566492fd0ff3b9c39&l=5, but it is from a background page, but not a Service Worker.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf08f95f54248eeb99a3af98b20816f3fde1f810

commit bf08f95f54248eeb99a3af98b20816f3fde1f810
Author: Istiaque Ahmed <lazyboy@chromium.org>
Date: Tue Oct 02 01:22:04 2018

Make runtime.onInstalled work for Service Worker based extensions.

runtime.onInstalled depends on Dispatch*WithLazyListener. For
Service Workers, this wouldn't dispatch the event as the event
listener doens't exist. For event pages, this works as we
manually add a listener before calling Dispatch. This CL does
the same for service worker based extensions.

Bug:  888798 
Change-Id: I75dddc32613862464ba2bb73fd972ec1b0d2b03a
Reviewed-on: https://chromium-review.googlesource.com/1247190
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595679}
[modify] https://crrev.com/bf08f95f54248eeb99a3af98b20816f3fde1f810/chrome/browser/extensions/service_worker_apitest.cc
[add] https://crrev.com/bf08f95f54248eeb99a3af98b20816f3fde1f810/chrome/test/data/extensions/api_test/service_worker/worker_based_background/events_on_installed/manifest.json
[add] https://crrev.com/bf08f95f54248eeb99a3af98b20816f3fde1f810/chrome/test/data/extensions/api_test/service_worker/worker_based_background/events_on_installed/service_worker_background.js
[modify] https://crrev.com/bf08f95f54248eeb99a3af98b20816f3fde1f810/extensions/browser/event_router.cc
[modify] https://crrev.com/bf08f95f54248eeb99a3af98b20816f3fde1f810/extensions/common/api/_api_features.json

Status: Fixed (was: Started)

Sign in to add a comment