New issue
Advanced search Search tips

Issue 888786 link

Starred by 2 users

Issue metadata

Status: Unconfirmed
Owner:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: ----



Sign in to add a comment

Better download failure information on notifications

Project Member Reported by qin...@chromium.org, Sep 24

Issue description

Currently android just show "download failed", we need better information about the failure reasons
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1fb56f86bfe2f3652a9c9b463438dac232df759

commit e1fb56f86bfe2f3652a9c9b463438dac232df759
Author: Min Qin <qinmin@chromium.org>
Date: Tue Oct 02 22:00:20 2018

Showing more details for Download error notifications.

This CL exposes more details on the notification for failed downloads.

BUG=888786

Change-Id: I1c98621a33977359eea0636fa1120c65f3080a7f
Reviewed-on: https://chromium-review.googlesource.com/c/1242040
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Jian Li <jianli@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595998}
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier2.java
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/android/java/src/org/chromium/chrome/browser/download/items/OfflineContentAggregatorNotificationBridgeUi.java
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/android/junit/src/org/chromium/chrome/browser/download/items/OfflineContentAggregatorNotificationBridgeUiTest.java
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/browser/BUILD.gn
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/browser/android/download/download_manager_service.cc
[add] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/browser/android/download/download_utils.cc
[add] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/browser/android/download/download_utils.h
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/browser/download/download_commands.cc
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/browser/download/download_item_model.cc
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/browser/download/download_item_model.h
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/browser/download/download_ui_model.cc
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/browser/download/download_ui_model.h
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/browser/download/offline_item_model.cc
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/browser/download/offline_item_model.h
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/browser/download/offline_item_utils.cc
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/browser/download/offline_item_utils.h
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/chrome/browser/offline_pages/android/downloads/offline_page_share_helper.cc
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/components/download/internal/common/download_file_impl.cc
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/components/offline_items_collection/core/fail_state.h
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/components/offline_items_collection/core/test_support/offline_item_test_support.cc
[modify] https://crrev.com/e1fb56f86bfe2f3652a9c9b463438dac232df759/components/offline_pages/core/background/save_page_request.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c594289e7b3f0d91c021ed3a5de6385513eabbd

commit 0c594289e7b3f0d91c021ed3a5de6385513eabbd
Author: Min Qin <qinmin@chromium.org>
Date: Thu Oct 04 01:01:14 2018

Match download error notification message with that on download shelf

Currently we use something like "No permission" for notification text.
On download shelf, it is "Failed - No Permission", which is better as
user will know download actually failed.

BUG=888786

Change-Id: I0e7809d1a06db454cfe43c5df05da58595a02b31
Reviewed-on: https://chromium-review.googlesource.com/c/1259223
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596457}
[modify] https://crrev.com/0c594289e7b3f0d91c021ed3a5de6385513eabbd/chrome/browser/android/download/download_utils.cc

Sign in to add a comment