WebUiScreenLockerTest crashes with SingleProcessMash |
|||
Issue descriptionRunning interactive_ui_tests with --enable-features=SingleProcessMash, WebUiScreenLockerTest's TestBasic and TestFullscreenExit crashes due to a CHECK failure: [84279:84279:0924/150716.904250:FATAL:window.cc(380)] Check failed: env_ == child->env_ (0x3bc4893d2aa0 vs. 0x3bc48888d8e0)All windows in a hierarchy must share the same Env. That's because the screenlocker is created under the LockScreenContainer in Ash while the webcontents is created within the browser process. This happens on chrome itself, however it needs --show-webui-lock flag. Maybe we can ignore them for Mash?
,
Sep 25
Not in production, WebUI-based screen locker is only activated through --show-webui-lock flag as I mentioned above, and this flag seems not controllable from about:flags. Maybe there is some timeline for the deprecation -- jdufault@ might have that?
,
Sep 25
,
Sep 25
FYI --show-webui-lock is deprecated at this point and will be removed within the next few milestones. It should be okay to filter these tests out for mash.
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0a8f7866c2ff2a6446c77e2db70a3fe164c83df commit f0a8f7866c2ff2a6446c77e2db70a3fe164c83df Author: Jun Mukai <mukai@chromium.org> Date: Wed Sep 26 00:00:52 2018 Skip WebUiScreenLocker for Mash BUG= 888779 TEST=interactive_ui_tests --enable-features=SingleProcessMash Change-Id: If0653a7dae1e7c156f122680fd6be71b001dd9f3 Reviewed-on: https://chromium-review.googlesource.com/1244300 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#594147} [modify] https://crrev.com/f0a8f7866c2ff2a6446c77e2db70a3fe164c83df/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc
,
Sep 26
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sky@chromium.org
, Sep 25