New issue
Advanced search Search tips

Issue 888755 link

Starred by 2 users
Status: Fixed
Owner:
jarhar@chromium.org
Closed: Nov 9
Cc:
pfeldman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

"Save as HAR with content" misplaced menu item

Reported by jidanni@gmail.com, Sep 24 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.92 Safari/537.36

Steps to reproduce the problem:
1. In Network tab
2. Right click on an item
3. Click on "Save as HAR with content"

What is the expected behavior?
Will save this one item as HAR with content

What went wrong?
Saves all the items below and above it too as HAR with content.

Did this work before? N/A 

Chrome version: 69.0.3497.92  Channel: n/a
OS Version: 
Flash Version: 

Should only save this one item as HAR with content.

What if in some operating system we clicked on a file in a directory and then clicked on Delete and it deleted all the files below and above it too.

Or we clicked on a photo and clicked send, and it sent all the other photos in the album as an extra bonus.

Please also create "Save all as HAR with content" and place it in a main menu.

Comment 1 by caseq@chromium.org, Sep 24

Cc: pfeldman@chromium.org
Components: -Platform>DevTools Platform>DevTools>Network
Owner: hhli@chromium.org
Status: Assigned (was: Unconfirmed)
I think we do this on purpose now, but the item title could perhaps state this more explicitly, e.g. "Save all as HAR with content".

Comment 2 by jidanni@gmail.com, Sep 24 

You perhaps need two choices then, possibly organized into a submenu
"Save as HAR with content".
"Save all as HAR with content".

And need a new default filename to save to for the future fixed "Save as HAR with content".

Anyway, some users just want to save that one HAR and not the gobs and gobs of other stuff there.

Comment 3 by jarhar@chromium.org, Oct 11

Owner: jarhar@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db8ffec4d7bf85a59a71eaa3371413d3137e91d5

commit db8ffec4d7bf85a59a71eaa3371413d3137e91d5
Author: Joey Arhar <jarhar@chromium.org>
Date: Tue Nov 06 00:24:20 2018

[DevTools] Change "save as HAR" to "save all as HAR"

Bug:  888755 
Change-Id: I428409372cf99d527db0da7771198cdd14cacea7
Reviewed-on: https://chromium-review.googlesource.com/c/1318181
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605532}
[modify] https://crrev.com/db8ffec4d7bf85a59a71eaa3371413d3137e91d5/third_party/blink/renderer/devtools/front_end/network/NetworkLogView.js

Comment 5 by jarhar@chromium.org, Nov 9

Status: Fixed (was: Assigned)
►

Sign in to add a comment