New issue
Advanced search Search tips

Issue 888753 link

Starred by 1 user
Status: Verified
Owner:
kmarshall@chromium.org
Closed: Oct 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

Use Fuchsia SDK file manifests for build definitions

Project Member Reported by kmarshall@chromium.org, Sep 24 
The Fuchsia SDK now includes manifest JSON files.

We should write a programmatic solution for building BUILD.gn definitions from these manifest files, so that we don't need to maintain a parallel set of target definitions. Maintaining those parallel definitions is a source of frequent breakages.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9

commit dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed Sep 26 17:17:13 2018

[fuchsia] Generate BUILD.gn from SDK metadata, migrate FIDL targets.

This script uses the metadata JSON files in the SDK to generate a
BUILD.gn in //third_party/fuchsia-sdk/sdk. The build file is
regenerated whenever a new SDK is downloaded using "gclient sync".

Only FIDL libraries are migrated for now. Additional metadata types can
be migrated in followup CLs.


Bug:  888753 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If87010006cd23e90d970da4cb84e6de35804b7dd
Reviewed-on: https://chromium-review.googlesource.com/1241842
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594360}
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/build/fuchsia/update_sdk.py
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/content/common/BUILD.gn
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/content/shell/BUILD.gn
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/media/audio/BUILD.gn
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/net/BUILD.gn
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/skia/BUILD.gn
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/third_party/fuchsia-sdk/BUILD.gn
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/third_party/fuchsia-sdk/fuchsia_sdk_pkg.gni
[add] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/third_party/fuchsia-sdk/gen_build_defs.py
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/tools/fuchsia/local-sdk.py
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/ui/base/ime/BUILD.gn
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/ui/events/BUILD.gn
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/ui/ozone/demo/BUILD.gn
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/ui/ozone/platform/scenic/BUILD.gn
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/ui/platform_window/BUILD.gn
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/webrunner/BUILD.gn
[modify] https://crrev.com/dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9/webrunner/net_http/BUILD.gn
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02086b936ca667766ef89c7703186fd40e35550d

commit 02086b936ca667766ef89c7703186fd40e35550d
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Wed Sep 26 17:36:38 2018

Revert "[fuchsia] Generate BUILD.gn from SDK metadata, migrate FIDL targets."

This reverts commit dfd34b91e8de763ae7fc52eb12a7534a3e4b97a9.

Reason for revert:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20ARM64%20Cast%20Audio/37042
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64%20Cast%20Audio/36915

Original change's description:
> [fuchsia] Generate BUILD.gn from SDK metadata, migrate FIDL targets.
> 
> This script uses the metadata JSON files in the SDK to generate a
> BUILD.gn in //third_party/fuchsia-sdk/sdk. The build file is
> regenerated whenever a new SDK is downloaded using "gclient sync".
> 
> Only FIDL libraries are migrated for now. Additional metadata types can
> be migrated in followup CLs.
> 
> 
> Bug:  888753 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: If87010006cd23e90d970da4cb84e6de35804b7dd
> Reviewed-on: https://chromium-review.googlesource.com/1241842
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594360}

TBR=sky@chromium.org,kmarshall@chromium.org,sergeyu@chromium.org,scottmg@chromium.org

Change-Id: If818310da713c18990fbed0f6c006bb90d41100d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  888753 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1246296
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594372}
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/build/fuchsia/update_sdk.py
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/content/common/BUILD.gn
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/content/shell/BUILD.gn
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/media/audio/BUILD.gn
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/net/BUILD.gn
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/skia/BUILD.gn
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/third_party/fuchsia-sdk/BUILD.gn
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/third_party/fuchsia-sdk/fuchsia_sdk_pkg.gni
[delete] https://crrev.com/0766524e2ddb63ef373133ee47b2e8e0161d65d7/third_party/fuchsia-sdk/gen_build_defs.py
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/tools/fuchsia/local-sdk.py
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/ui/base/ime/BUILD.gn
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/ui/events/BUILD.gn
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/ui/ozone/demo/BUILD.gn
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/ui/ozone/platform/scenic/BUILD.gn
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/ui/platform_window/BUILD.gn
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/webrunner/BUILD.gn
[modify] https://crrev.com/02086b936ca667766ef89c7703186fd40e35550d/webrunner/net_http/BUILD.gn
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/386fa9a70028f97ce511bc7bf84e5ce96e47f926

commit 386fa9a70028f97ce511bc7bf84e5ce96e47f926
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Wed Sep 26 19:14:20 2018

[fuchsia] Reland "Generate BUILD.gn from SDK metadata..."

Reland of CL https://chromium-review.googlesource.com/c/chromium/src/+/1241842.
(Confirmed that the code builds on Cast builders, and manually examined
all references to targets under //third_party/fuchsia-sdk to verify
that all FIDL targets have been modified to reference the new sdk/
subdir.)

This script uses the metadata JSON files in the SDK to generate a
BUILD.gn in //third_party/fuchsia-sdk/sdk. The build file is
regenerated whenever a new SDK is downloaded using "gclient sync".

Only FIDL libraries are migrated for now. Additional metadata types can
be migrated in followup CLs.

TBR=scottmg@chromium.org
TBR=sky@chromium.org

Bug:  888753 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7ec714982cdfbb6f6ccd8fad3cd7cbb48af4eb1c
Reviewed-on: https://chromium-review.googlesource.com/1246681
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594419}
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/build/fuchsia/update_sdk.py
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/chromecast/media/cma/backend/fuchsia/BUILD.gn
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/content/common/BUILD.gn
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/content/shell/BUILD.gn
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/media/audio/BUILD.gn
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/net/BUILD.gn
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/skia/BUILD.gn
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/third_party/fuchsia-sdk/BUILD.gn
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/third_party/fuchsia-sdk/fuchsia_sdk_pkg.gni
[add] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/third_party/fuchsia-sdk/gen_build_defs.py
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/tools/fuchsia/local-sdk.py
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/ui/base/ime/BUILD.gn
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/ui/events/BUILD.gn
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/ui/ozone/demo/BUILD.gn
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/ui/ozone/platform/scenic/BUILD.gn
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/ui/platform_window/BUILD.gn
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/webrunner/BUILD.gn
[modify] https://crrev.com/386fa9a70028f97ce511bc7bf84e5ce96e47f926/webrunner/net_http/BUILD.gn
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/712b34569c5dad99d67ad7ade9e4c456f61a3de0

commit 712b34569c5dad99d67ad7ade9e4c456f61a3de0
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Sep 27 11:37:46 2018

Revert "[fuchsia] Reland "Generate BUILD.gn from SDK metadata...""

This reverts commit 386fa9a70028f97ce511bc7bf84e5ce96e47f926.

Reason for revert:
Broke the fuchsia_sdk update step, see bug.

Original change's description:
> [fuchsia] Reland "Generate BUILD.gn from SDK metadata..."
> 
> Reland of CL https://chromium-review.googlesource.com/c/chromium/src/+/1241842.
> (Confirmed that the code builds on Cast builders, and manually examined
> all references to targets under //third_party/fuchsia-sdk to verify
> that all FIDL targets have been modified to reference the new sdk/
> subdir.)
> 
> This script uses the metadata JSON files in the SDK to generate a
> BUILD.gn in //third_party/fuchsia-sdk/sdk. The build file is
> regenerated whenever a new SDK is downloaded using "gclient sync".
> 
> Only FIDL libraries are migrated for now. Additional metadata types can
> be migrated in followup CLs.
> 
> TBR=scottmg@chromium.org
> TBR=sky@chromium.org
> 
> Bug:  888753 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I7ec714982cdfbb6f6ccd8fad3cd7cbb48af4eb1c
> Reviewed-on: https://chromium-review.googlesource.com/1246681
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594419}

TBR=kmarshall@chromium.org

Change-Id: I1a89a1c3d8223e6dd58e2a4b23f251eb96a7bba8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  888753 ,  889839 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1249203
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594671}
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/build/fuchsia/update_sdk.py
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/chromecast/media/cma/backend/fuchsia/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/content/common/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/content/shell/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/media/audio/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/net/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/skia/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/third_party/fuchsia-sdk/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/third_party/fuchsia-sdk/fuchsia_sdk_pkg.gni
[delete] https://crrev.com/c354aa9af805705f827519f7c87522e8f21634f1/third_party/fuchsia-sdk/gen_build_defs.py
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/tools/fuchsia/local-sdk.py
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/ui/base/ime/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/ui/events/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/ui/ozone/demo/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/ui/ozone/platform/scenic/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/ui/platform_window/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/webrunner/BUILD.gn
[modify] https://crrev.com/712b34569c5dad99d67ad7ade9e4c456f61a3de0/webrunner/net_http/BUILD.gn

Comment 5 by kmarshall@chromium.org, Oct 11

Status: Verified (was: Assigned)

Comment 6 by w...@chromium.org, Oct 17

Labels: -Pri-2 -M-71 M-72 Pri-1
Status: Assigned (was: Verified)
Kevin, can we get this fixed & re-landed ASAP, please?
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87c850207e26babd15dbec3cf4932e2aea5e5078

commit 87c850207e26babd15dbec3cf4932e2aea5e5078
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Tue Oct 23 00:29:44 2018

Fuchsia: Use SDK manifest for CC prebuilt and source packages.

Finishes the switch from using hand-rolled SDK target definitions to
using targets automatically generated from SDK metadata files. A
slightly oddball Vulkan copy rule remains intact.

* Remove the old targets from fuchsia_sdk/BUILD.gn
* Switch existing dependents of fuchsia_sdk:* targets to use
  fuchsia_sdk/sdk:* instead.
* Some "gn format" fixups.

TBR=jam@chromium.org

Bug:  888753 
Change-Id: I3aa9e6aa68cebae343609fc85c9a1c7d0ed1c7aa
Reviewed-on: https://chromium-review.googlesource.com/c/1292570
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601799}
[modify] https://crrev.com/87c850207e26babd15dbec3cf4932e2aea5e5078/base/BUILD.gn
[modify] https://crrev.com/87c850207e26babd15dbec3cf4932e2aea5e5078/base/test/BUILD.gn
[modify] https://crrev.com/87c850207e26babd15dbec3cf4932e2aea5e5078/build/config/fuchsia/fidl_library.gni
[modify] https://crrev.com/87c850207e26babd15dbec3cf4932e2aea5e5078/content/common/BUILD.gn
[modify] https://crrev.com/87c850207e26babd15dbec3cf4932e2aea5e5078/mojo/core/BUILD.gn
[modify] https://crrev.com/87c850207e26babd15dbec3cf4932e2aea5e5078/mojo/public/cpp/platform/BUILD.gn
[modify] https://crrev.com/87c850207e26babd15dbec3cf4932e2aea5e5078/net/BUILD.gn
[modify] https://crrev.com/87c850207e26babd15dbec3cf4932e2aea5e5078/third_party/crashpad/crashpad/third_party/fuchsia/BUILD.gn
[modify] https://crrev.com/87c850207e26babd15dbec3cf4932e2aea5e5078/third_party/fuchsia-sdk/BUILD.gn
[modify] https://crrev.com/87c850207e26babd15dbec3cf4932e2aea5e5078/third_party/fuchsia-sdk/fuchsia_sdk_pkg.gni
[modify] https://crrev.com/87c850207e26babd15dbec3cf4932e2aea5e5078/third_party/fuchsia-sdk/gen_build_defs.py
[modify] https://crrev.com/87c850207e26babd15dbec3cf4932e2aea5e5078/third_party/googletest/BUILD.gn
[modify] https://crrev.com/87c850207e26babd15dbec3cf4932e2aea5e5078/tools/fuchsia/fidlgen_js/BUILD.gn

Comment 8 by kmarshall@chromium.org, Oct 30

Status: Verified (was: Assigned)
Build targets are now switched over.
►

Sign in to add a comment