New issue
Advanced search Search tips

Issue 888746 link

Starred by 1 user
Status: Fixed
Owner:
ksakamoto@chromium.org
Closed: Sep 27
Cc:
kouhei@chromium.org
ksakamoto@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Flakiness in virtual/sxg/http/tests/loading/sxg/sxg-usecounter.html

Project Member Reported by erikc...@chromium.org, Sep 24 
The test failed twice on an otherwise unrelated CL.

See https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/90846

Looks like a timeout:
"""
main frame - didStartProvisionalLoadForFrame
main frame - didCommitLoadForFrame
main frame - didReceiveTitle: SignedHTTPExchange UseCounter
main frame - didFinishDocumentLoadForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didFinishLoadForFrame
frame "sxg_iframe" - didReceiveTitle: 
frame "sxg_iframe" - didStartProvisionalLoadForFrame
frame "sxg_iframe" - didFailProvisionalLoadWithError
This is a testharness.js-based test.
FAIL SignedHTTPExchange inner response documents are use counted. promise_test: Unhandled rejection with value: "timeout"
Harness: the test ran to completion.
"""

Comment 1 by tkent@chromium.org, Sep 25

Cc: ksakamoto@chromium.org kouhei@chromium.org
Components: -Blink Blink>Loader
Labels: Test-Layout Test-Flaky

Comment 2 by ksakamoto@chromium.org, Sep 25

Owner: ksakamoto@chromium.org
Let's extend the 1000ms timeout and see if it helps.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/205facbaa3747cc02ff4473389e65174ec7710d8

commit 205facbaa3747cc02ff4473389e65174ec7710d8
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Tue Sep 25 09:26:14 2018

Refactor SignedExchange layout tests and increase timeout

- Factor out the code creating iframe for SXG and waiting for a message
- Increase the timeout from 1000ms to 2000ms, to address test flakiness

Bug:  888746 
Change-Id: I203e2956e91ebd57c0f5ba4f1b41fc78b023884a
Reviewed-on: https://chromium-review.googlesource.com/1242724
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593875}
[modify] https://crrev.com/205facbaa3747cc02ff4473389e65174ec7710d8/third_party/WebKit/LayoutTests/http/tests/loading/sxg/fallback-to-another-sxg.html
[modify] https://crrev.com/205facbaa3747cc02ff4473389e65174ec7710d8/third_party/WebKit/LayoutTests/http/tests/loading/sxg/nested-sxg.html
[modify] https://crrev.com/205facbaa3747cc02ff4473389e65174ec7710d8/third_party/WebKit/LayoutTests/http/tests/loading/sxg/resources/sxg-util.js
[modify] https://crrev.com/205facbaa3747cc02ff4473389e65174ec7710d8/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-expired.html
[modify] https://crrev.com/205facbaa3747cc02ff4473389e65174ec7710d8/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-fallback-with-fragment.html
[modify] https://crrev.com/205facbaa3747cc02ff4473389e65174ec7710d8/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-invalid-validity-url.html
[modify] https://crrev.com/205facbaa3747cc02ff4473389e65174ec7710d8/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-location-fragment.html
[modify] https://crrev.com/205facbaa3747cc02ff4473389e65174ec7710d8/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-location-origin-trial.html
[modify] https://crrev.com/205facbaa3747cc02ff4473389e65174ec7710d8/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-location.html
[modify] https://crrev.com/205facbaa3747cc02ff4473389e65174ec7710d8/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-non-secure-origin.html
[modify] https://crrev.com/205facbaa3747cc02ff4473389e65174ec7710d8/third_party/WebKit/LayoutTests/http/tests/loading/sxg/sxg-usecounter.html
[modify] https://crrev.com/205facbaa3747cc02ff4473389e65174ec7710d8/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial-with-network-service/http/tests/loading/sxg/sxg-invalid-validity-url-expected.txt
[modify] https://crrev.com/205facbaa3747cc02ff4473389e65174ec7710d8/third_party/WebKit/LayoutTests/virtual/sxg-origin-trial/http/tests/loading/sxg/sxg-invalid-validity-url-expected.txt

Comment 4 by ksakamoto@chromium.org, Sep 27

Status: Fixed (was: Untriaged)
►

Sign in to add a comment