New issue
Advanced search Search tips

Issue 888743 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in CPDF_ColorSpace::CountComponents

Project Member Reported by ClusterFuzz, Sep 24

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4655420222996480

Fuzzer: ifratric_pdf_generic
Job Type: linux_asan_pdfium
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000020
Crash State:
  CPDF_ColorSpace::CountComponents
  CPDF_DIBBase::LoadJpxBitmap
  CPDF_DIBBase::CreateDecoder
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_pdfium&range=593605:593606

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4655420222996480

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Sep 24

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Sep 24

Labels: Test-Predator-Auto-Owner
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://pdfium.googlesource.com/pdfium/+/214982c4d02a720c3b1b3de121cddc62189b8848 (Remove unreachable code in CPDF_DIBBase.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Status: Started (was: Assigned)
I'm going to revert my CL.
Project Member

Comment 4 by ClusterFuzz, Sep 25

Labels: OS-Mac
Cc: thestig@chromium.org
 Issue 888941  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/2a1cbc0417985485ab660ee6fd98c3bbedf716cd

commit 2a1cbc0417985485ab660ee6fd98c3bbedf716cd
Author: Lei Zhang <thestig@chromium.org>
Date: Tue Sep 25 20:07:29 2018

Revert "Remove unreachable code in CPDF_DIBBase."

This reverts commit 214982c4d02a720c3b1b3de121cddc62189b8848.

Reason for revert: Turns out it is reachable.

Original change's description:
> Remove unreachable code in CPDF_DIBBase.
> 
> The colorspace is always available when creating image decoders that use
> colorspaces.
> 
> Change-Id: I20ac75edcd614ccc1e83de262c128776e9d03eed
> Reviewed-on: https://pdfium-review.googlesource.com/42872
> Commit-Queue: Ryan Harrison <rharrison@chromium.org>
> Reviewed-by: Ryan Harrison <rharrison@chromium.org>

TBR=thestig@chromium.org,rharrison@chromium.org
BUG= chromium:888743 

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I45903543f0e4bf2785660fb8c1e45c34febb6ecf
Reviewed-on: https://pdfium-review.googlesource.com/43050
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/2a1cbc0417985485ab660ee6fd98c3bbedf716cd/core/fxcodec/codec/ccodec_jpxmodule.cpp
[modify] https://crrev.com/2a1cbc0417985485ab660ee6fd98c3bbedf716cd/core/fpdfapi/render/cpdf_dibbase.cpp

Status: Fixed (was: Started)
 Issue 889218  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd49d8ac824dd79a5087d735790e16a076faf410

commit cd49d8ac824dd79a5087d735790e16a076faf410
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Sep 25 22:06:42 2018

Roll src/third_party/pdfium 30dc6aaf878b..9412c8ec36d1 (3 commits)

https://pdfium.googlesource.com/pdfium.git/+log/30dc6aaf878b..9412c8ec36d1


git log 30dc6aaf878b..9412c8ec36d1 --date=short --no-merges --format='%ad %ae %s'
2018-09-25 thestig@chromium.org Get rid of "exceptions" in CBC_QRCoderMatrixUtil.
2018-09-25 thestig@chromium.org Roll third_party/freetype/src/ dfddc2d97..abd997aa7 (9 commits)
2018-09-25 thestig@chromium.org Revert "Remove unreachable code in CPDF_DIBBase."


Created with:
  gclient setdep -r src/third_party/pdfium@9412c8ec36d1

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:888743 
TBR=dsinclair@chromium.org

Change-Id: I81e542c61d7966800fd2d4efc2fc4a8f04e8cacc
Reviewed-on: https://chromium-review.googlesource.com/1244115
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#594122}
[modify] https://crrev.com/cd49d8ac824dd79a5087d735790e16a076faf410/DEPS

Project Member

Comment 10 by ClusterFuzz, Sep 26

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4699477024440320 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by ClusterFuzz, Sep 26

ClusterFuzz has detected this issue as fixed in range 594120:594122.

Detailed report: https://clusterfuzz.com/testcase?key=4655420222996480

Fuzzer: ifratric_pdf_generic
Job Type: linux_asan_pdfium
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000020
Crash State:
  CPDF_ColorSpace::CountComponents
  CPDF_DIBBase::LoadJpxBitmap
  CPDF_DIBBase::CreateDecoder
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_pdfium&range=593605:593606
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_pdfium&range=594120:594122

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4655420222996480

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment