New issue
Advanced search Search tips

Issue 888721 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Content shell APK crashes in first_meaningful_paint_detector.cc on startup

Project Member Reported by mthiesse@chromium.org, Sep 24

Issue description

Build and run content shell APK in debug config:
autoninja -C out/Debug content_shell_apk && out/Debug/bin/content_shell_apk run

Shortly after loading the startup URL, it will crash:

FATAL:first_meaningful_paint_detector.cc(270)] Check failed: !swap_stamp.is_null().
Stack Trace:
  RELADDR   FUNCTION                                                                                                                                                                               FILE:LINE
  027ab95f  logging::LogMessage::~LogMessage()                                                                                                                                                     /usr/local/google/home/mthiesse/src/dodo/src/base/logging.cc:599:29
  03c4a153  blink::FirstMeaningfulPaintDetector::SetFirstMeaningfulPaint(base::TimeTicks, base::TimeTicks)                                                                                         /usr/local/google/home/mthiesse/src/dodo/src/third_party/blink/renderer/core/paint/first_meaningful_paint_detector.cc:270:3
  03c4a0e5  blink::FirstMeaningfulPaintDetector::OnNetwork2Quiet()                                                                                                                                 /usr/local/google/home/mthiesse/src/dodo/src/third_party/blink/renderer/core/paint/first_meaningful_paint_detector.cc:158:7


Bisected to https://chromium-review.googlesource.com/c/chromium/src/+/1185441. Would be great if we could get this fixed, downstream projects use content shell.
 
Hi,

 Can you send full build instructions of the apk like what args.gn i will need etc.
i have never built this so will need full instructions.
This is Android only, so you'll need to follow Android setup instructions.

My Debug gn args are:
target_os = "android"
use_goma = true
is_debug = true
is_component_build = false
disable_incremental_isolated_processes = true
is_clang = true
target_cpu = "arm"
Looks like this only repros on my gobo phone (huawei). I've got a 512 MB gobo OMR1 image flashed, so maybe low memory is the issue somehow.


Cc: sadrul@chromium.org
This patch will most probably fix the issue.


Project Member

Comment 6 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84a4df1c6bee3a5312e57877368b5828181bef8d

commit 84a4df1c6bee3a5312e57877368b5828181bef8d
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Wed Oct 10 18:28:56 2018

android: Fix invalid presentation timestamp.

According to the documentation [1], it is possible for
eglGetFrameTimestampsANDROID to succeed, and yet return in invalid
timestamp (as EGL_TIMESTAMP_INVALID_ANDROID). In such cases, the event
is not expected to happen again. Therefore, report the current-time as
the presentation-time.

[1] https://www.khronos.org/registry/EGL/extensions/ANDROID/EGL_ANDROID_get_frame_timestamps.txt

BUG= 888721 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I05e586722bbcb8d05027ce3dddc4e9f845d11f32
Reviewed-on: https://chromium-review.googlesource.com/c/1272805
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598414}
[modify] https://crrev.com/84a4df1c6bee3a5312e57877368b5828181bef8d/ui/gl/gl_surface_egl.cc

Owner: sadrul@chromium.org
Is this fixed now?
Status: Fixed (was: Assigned)
It's fixed, I haven't been able to repro.

Sign in to add a comment