New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 888715 link

Starred by 2 users
Status: Assigned
Owner:
yiyix@chromium.org
Cc:
samans@chromium.org
rjkroege@chromium.org
vmiura@google.com
sadrul@chromium.org
piman@chromium.org
█ gklassen@chromium.org
yiyix@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

cc / viz / gpu metrics should be bucketed per client type

Project Member Reported by fsam...@chromium.org, Sep 24 
Graphics UMA metrics are currently bucketed under either "Browser" or "Renderer" but that is not entirely accurate and could skew results to look better than they actually are today.

In particular, we have many clients in Chrome today that are not browser UI or top level renderers: OOPIFs, offscreen canvas, video surfaces, exo, soon OOP-Ash, etc.

If the web today consists of a bunch of small OOPIFs, then that could make top level page look better than they actually are.

Exo and Ash could skew "browser" UMA.

We should replace GetClientNameForMetrics with something that is scoped per LayerTreeHost and/or AsyncLayerTreeFrameSink.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b90ef589bb4025092e18898d6a5768afa0dd767

commit 6b90ef589bb4025092e18898d6a5768afa0dd767
Author: yiyix <yiyix@chromium.org>
Date: Tue Oct 09 19:55:30 2018

OOPIF (per-client) graphics pipeline metrics

Graphics UMA metrics are currently bucketed under either
"Browser" or "Renderer" but that is not entirely accurate
and could skew results to look better than they actually
are today.

In this patch, I added 2 new clients OOPIF and TopLevel.
I kept metrics under Browser and Renderer for now.

Bug: 888715

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie4fee2183d9fda46b72649d422c750cf88577223
Reviewed-on: https://chromium-review.googlesource.com/c/1241293
Commit-Queue: Yi Xu <yiyix@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598048}
[modify] https://crrev.com/6b90ef589bb4025092e18898d6a5768afa0dd767/cc/mojo_embedder/async_layer_tree_frame_sink.cc
[modify] https://crrev.com/6b90ef589bb4025092e18898d6a5768afa0dd767/cc/mojo_embedder/async_layer_tree_frame_sink.h
[modify] https://crrev.com/6b90ef589bb4025092e18898d6a5768afa0dd767/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/6b90ef589bb4025092e18898d6a5768afa0dd767/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/6b90ef589bb4025092e18898d6a5768afa0dd767/content/renderer/render_thread_impl.h
[modify] https://crrev.com/6b90ef589bb4025092e18898d6a5768afa0dd767/content/renderer/render_widget.cc
[modify] https://crrev.com/6b90ef589bb4025092e18898d6a5768afa0dd767/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/6b90ef589bb4025092e18898d6a5768afa0dd767/ui/aura/local/window_port_local.cc
[modify] https://crrev.com/6b90ef589bb4025092e18898d6a5768afa0dd767/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/6b90ef589bb4025092e18898d6a5768afa0dd767/ui/compositor/host/host_context_factory_private.cc
►

Sign in to add a comment