New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 888710 link

Starred by 2 users
Status: Duplicate
Merged: issue 889079
Owner:
█ yunlian@chromium.org
Last visit > 30 days ago
Closed: Oct 10
Cc:
apronin@chromium.org
briannorris@chromium.org
yamaguchi@chromium.org
xiaoh...@chromium.org
cmt...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

chromeos-chrome: oak failed to build with simple chorme

Project Member Reported by yunlian@chromium.org, Sep 24 
On oark-release, I got below errors. It turns out that libassistant is 
using bfd linker.
python "../../../../../../chromeos/assistant/libassistant/src/build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --sofile="./libassistant.so" --tocfile="./libassistant.so.TOC" --output="./libassistant.so"  -- armv7a-cros-linux-gnueabihf-clang++ -B/b/swarming/w/ir/tmp/t/cbuildbot-tmpzAgUtI/chrome-sdk-cachec7o4q4/cache/chrome-sdk/tarballs/oak+__b__swarming__w__ir__cache__cbuild__repository__trybot_archive__oak-release-tryjob__R71-11086.0.0-b2965504+target_toolchain/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabihf/binutils-bin/2.27.0-gold -Wno-unknown-warning-option -shared -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=bfd --target=arm-linux-gnueabihf -Wl,-O2 -Wl,--gc-sections --sysroot=../../../../../../../../../../../../../../tmp/t/cbuildbot-tmpzAgUtI/chrome-sdk-cachec7o4q4/cache/chrome-sdk/tarballs/oak+__b__swarming__w__ir__cache__cbuild__repository__trybot_archive__oak-release-tryjob__R71-11086.0.0-b2965504+sysroot_chromeos-base_chromeos-chrome.tar.xz -L../../../../../../../../../../../../../../tmp/t/cbuildbot-tmpzAgUtI/chrome-sdk-cachec7o4q4/cache/chrome-sdk/tarballs/oak+__b__swarming__w__ir__cache__cbuild__repository__trybot_archive__oak-release-tryjob__R71-11086.0.0-b2965504+sysroot_chromeos-base_chromeos-chrome.tar.xz/lib -Wl,-rpath-link=../../../../../../../../../../../../../../tmp/t/cbuildbot-tmpzAgUtI/chrome-sdk-cachec7o4q4/cache/chrome-sdk/tarballs/oak+__b__swarming__w__ir__cache__cbuild__repository__trybot_archive__oak-release-tryjob__R71-11086.0.0-b2965504+sysroot_chromeos-base_chromeos-chrome.tar.xz/lib -L../../../../../../../../../../../../../../tmp/t/cbuildbot-tmpzAgUtI/chrome-sdk-cachec7o4q4/cache/chrome-sdk/tarballs/oak+__b__swarming__w__ir__cache__cbuild__repository__trybot_archive__oak-release-tryjob__R71-11086.0.0-b2965504+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/lib -Wl,-rpath-link=../../../../../../../../../../../../../../tmp/t/cbuildbot-tmpzAgUtI/chrome-sdk-cachec7o4q4/cache/chrome-sdk/tarballs/oak+__b__swarming__w__ir__cache__cbuild__repository__trybot_archive__oak-release-tryjob__R71-11086.0.0-b2965504+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/lib -L../../../../../../../../../../../../../../tmp/t/cbuildbot-tmpzAgUtI/chrome-sdk-cachec7o4q4/cache/chrome-sdk/tarballs/oak+__b__swarming__w__ir__cache__cbuild__repository__trybot_archive__oak-release-tryjob__R71-11086.0.0-b2965504+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/local/lib -Wl,-rpath-link=../../../../../../../../../../../../../../tmp/t/cbuildbot-tmpzAgUtI/chrome-sdk-cachec7o4q4/cache/chrome-sdk/tarballs/oak+__b__swarming__w__ir__cache__cbuild__repository__trybot_archive__oak-release-tryjob__R71-11086.0.0-b2965504+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/local/lib -static-libgcc -Wl,-O2 -Wl,--as-needed -Wl,--fix-cortex-a53-843419 -stdlib=libc++ -o "./libassistant.so" -Wl,-soname="libassistant.so" @"./libassistant.so.rsp"
/b/swarming/w/ir/tmp/t/cbuildbot-tmpzAgUtI/chrome-sdk-cachec7o4q4/cache/chrome-sdk/tarballs/oak+__b__swarming__w__ir__cache__cbuild__repository__trybot_archive__oak-release-tryjob__R71-11086.0.0-b2965504+target_toolchain/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabihf/binutils-bin/2.27.0/ld.bfd.real.elf: unrecognized option '--fix-cortex-a53-843419'
/b/swarming/w/ir/tmp/t/cbuildbot-tmpzAgUtI/chrome-sdk-cachec7o4q4/cache/chrome-sdk/tarballs/oak+__b__swarming__w__ir__cache__cbuild__repository__trybot_archive__oak-release-tryjob__R71-11086.0.0-b2965504+target_toolchain/usr/x86_64-pc-linux-gnu/armv7a-cros-linux-gnueabihf/binutils-bin/2.27.0/ld.bfd.real.elf: use the --help option for usage information
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/5024a05eccf5419bbfba6588d722bf8e7ba45c8f

commit 5024a05eccf5419bbfba6588d722bf8e7ba45c8f
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed Sep 26 17:32:44 2018

chromeos-chrome: pass use_gold to gn files

libassistant will try to use bfd linker is use_gold and use_lld is
not set to true. Currently we are using gold to link chrome and we
should pass use_gold=true to gn file in this case.

BUG= chromium:888710 
TEST=libassistant is using gold linker.

Change-Id: I76a767f0a7017b8bdb36660c26131b4c19fd3ad8
Reviewed-on: https://chromium-review.googlesource.com/1240816
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>

[modify] https://crrev.com/5024a05eccf5419bbfba6588d722bf8e7ba45c8f/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e496c3b99a48d37eb17f6ed7b8e84eccf650ce81

commit e496c3b99a48d37eb17f6ed7b8e84eccf650ce81
Author: Min Chen <minch@chromium.org>
Date: Thu Sep 27 18:34:22 2018

Revert "chromeos-chrome: pass use_gold to gn files"

This reverts commit 5024a05eccf5419bbfba6588d722bf8e7ba45c8f.

Reason for revert: Failed pfq at BuildPackages
                   The gold related flags are passed to nacl and
                    make the chrome PFQ fail. chromium:889584
https://luci-logdog.appspot.com/v/?s=chromeos/buildbucket/cr-buildbucket.appspot.com/8934293443791559424/+/steps/BuildPackages/0/stdout

Original change's description:
> chromeos-chrome: pass use_gold to gn files
>
> libassistant will try to use bfd linker is use_gold and use_lld is
> not set to true. Currently we are using gold to link chrome and we
> should pass use_gold=true to gn file in this case.
>
> BUG= chromium:888710 
> TEST=libassistant is using gold linker.
>
> Change-Id: I76a767f0a7017b8bdb36660c26131b4c19fd3ad8
> Reviewed-on: https://chromium-review.googlesource.com/1240816
> Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
> Tested-by: Yunlian Jiang <yunlian@chromium.org>
> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>

Bug:  chromium:889584 , chromium:888710 
Change-Id: I3ee7990e786cb7c5aa6a322fcd14e964c40f7be0
Reviewed-on: https://chromium-review.googlesource.com/1249608
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Tested-by: Min Chen <minch@chromium.org>

[modify] https://crrev.com/e496c3b99a48d37eb17f6ed7b8e84eccf650ce81/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 2 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/assistant/+/25b9fc9e3fc55af05db093a349eac3a82822d9d3

commit 25b9fc9e3fc55af05db093a349eac3a82822d9d3
Author: Xiaohui Chen <xiaohuic@google.com>
Date: Mon Oct 01 22:26:48 2018

Comment 4 by apronin@chromium.org, Oct 3

Cc: briannorris@chromium.org apronin@chromium.org
Labels: -Pri-3 Hotlist-CrOS-Sheriffing OS-Chrome Pri-2
Several recent oak-release builds failed with unrecognized option '--fix-cortex-a53-843419' error from ld.bfd.real.elf during TestSimpleChromeWorkflow.

Comment 5 by briannorris@chromium.org, Oct 3

Cc: yamaguchi@chromium.org

Comment 6 by xiaohuic@google.com, Oct 4 

The fix merged in #3 is in Chrome tree, so it would require a Chrome uprev to pick up.

Comment 7 by yunlian@chromium.org, Oct 10

Mergedinto: 889079
Status: Duplicate (was: Untriaged)
►

Sign in to add a comment