New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 888697 link

Starred by 3 users
Status: Fixed
Owner:
mdjones@chromium.org
Closed: Oct 12
Cc:
█ lzbylut@chromium.org
amaralp@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Duet] Use timeout for IPH bubble instead of dismissing on touch

Project Member Reported by mdjones@chromium.org, Sep 24 
Help bubbles dismissed on touch are usually on-screen for a very short amount of time. We should change the dismiss trigger to be a timeout.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ee1718649a86c66962175ebbfa3588fdc206011

commit 4ee1718649a86c66962175ebbfa3588fdc206011
Author: Matthew Jones <mdjones@chromium.org>
Date: Tue Sep 25 16:57:28 2018

Change Duet IPH to be dismissed via timeout

Touch-dismissal is too quick for the feature, this patch adds
a 6 second timeout instead.

Bug:  888697 
Change-Id: I5c3ca03435c634bd93f6255bc9af7b12abe89451
Reviewed-on: https://chromium-review.googlesource.com/1241136
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593972}
[modify] https://crrev.com/4ee1718649a86c66962175ebbfa3588fdc206011/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Comment 2 by mdjones@chromium.org, Oct 12

Status: Fixed (was: Started)
►

Sign in to add a comment