New issue
Advanced search Search tips

Issue 888688 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 23
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Console Log: Disabling "Preserve Log" doesn't disable preservation of log

Reported by swesni...@cashbet.com, Sep 24

Issue description

Chrome Version       : 69.0.3497.100
OS Version: OS X 10.13.6
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari:
    Firefox:
    IE/Edge:

What steps will reproduce the problem?
1. Open a page which has warnings, errors, or console logs upon load.
2. Hit Cmd Shift J to open chrome dev tools.
3. Click the Console Tab
4. Click the gear in the upper right corner to display console settings.
5. Observe that the "Preserve log" checkbox is unchecked.
6. Hit Cmd R to refresh the page
7. Observe the console scrolls down and keeps the logs shown before refresh.
8. Click the "Preserve Log" checkbox, enabling it, and refresh once more
9. Observe that, as expected now, the log is preserved.
10. Uncheck the "Preserve Log" checkbox once more and refresh
11. Observe that, unexpectedly, the logs continue to be preserved.

What is the expected result?
Logs should disappear upon refresh

What happens instead of that?
Logs continue to exist / logs still visible / logs continue to be preserved.

Please provide any additional information below. Attach a screenshot if
possible.

mp4 Attached showing cmd-R refreshes with checkbox off, then on, then off again.
Low resolution due to 10.0 MB limit for attaching files here.

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36



 
PreserveLog.mp4
1.5 MB View Download
Additonal Video showing F1 settings
PreserveLog2.mp4
5.9 MB View Download
Summary of problem and forum post regarding this bug here:
https://productforums.google.com/forum/#!topic/chrome/VyDkVeaRD98;context-place=forum/chrome
Labels: Needs-Triage-M69
Components: Platform>DevTools
Labels: -Needs-Triage-M69
Status: Untriaged (was: Unconfirmed)
Mac triage: marking for DevTools triage.
Owner: l...@chromium.org
Status: Assigned (was: Untriaged)
Labels: Needs-Feedback
Thanks for the report and screencasts.  I'm unable to reproduce this on: 69.0.3497.100 or 71.0.3564.0.

We've received similar reports in the past, but were unable to reproduce those cases either:
https://bugs.chromium.org/p/chromium/issues/detail?id=836390
https://bugs.chromium.org/p/chromium/issues/detail?id=805873

Do you happen to have a public URL we can use to test?
I have the exact same issue for some time now, at least back to July 2018 when I made a request to fix in another Google forum. It will produce the same result no matter what URL, i.e preserve log unchecked does not clear the log on page reload
Windows 10 1803 - Chrome 69.0.3497.100
Tracked it down to Adblock Plus extension (V3.3.2). Disabling that extension give the "Preserve Log" checkbox its expected behavior
 julesgil...@gmail.com is correct. Confirmed. Bug resolved by disabling adblock
For comments #7 - #10, could you please reproduce the bug, open DevTools-on-DevTools [1], and let us know if there are errors in the 2nd DevTools Console?

I'm unable to reproduce w/ Adblock Plus (3.3.2), Chrome 69.0.3497.100.

[1] https://stackoverflow.com/questions/12291138/how-do-you-inspect-the-web-inspector-in-chrome/12291163#12291163


I had removed the Adblock Plus extension to fix the problem. I have now installed it again (V3.3.2) and the issue with console clearing is back.

Attached is a screenshot of dev tools on dev tools console on fresh page load. Withouth ABP these errors are not present.

There are others reporting same issue on ABP support forum, no response or resolution there.
adblock_plus_devtools_on_devtools_error.jpg
96.4 KB View Download
Windows 10, Chrome 69.0.3497.100.  Also experiencing this issue.

I do not have AdBlock.  I have uBlock but don't think it's related, as I experience this issue with all extensions disabled (is disabling enough for a clean test?).

Have only noticed this issue since Chrome 69 I think.

I have only observed the issue while refreshing Angular dev mode page served from my own machine, accessed at http://my-pc-name/#/ or http://my-pc-name.internal.domain/#/.  I've compared to 3rd party sites and other intranet sites, and can't reproduce elsewhere.

Here are errors from dev-tools on dev-tools that occurred during/after refresh of my own page.

dev-tools-on-dev-tools-errors.png
99 KB View Download
Labels: -Needs-Feedback
Really appreciate the screenshots and details everyone.  I was finally able to reproduce this.

It seems to involve blackboxing a sourcemap + navigating the page.  AdBlock Plus just happens to have a sourcemap included, and many DevTools users have blackbox settings set to exclude content scripts.  Excluded sourcemaps did not get registered properly, so we threw errors upon navigation, preventing Console from properly clearing.

Working on a fix.
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/877430d2223351c42000a8fdef711514ca89e4df

commit 877430d2223351c42000a8fdef711514ca89e4df
Author: Erik Luo <luoe@chromium.org>
Date: Tue Oct 23 00:21:46 2018

[DevTools] fix(bindings): properly detach blackboxed sourcemaps

CompilerScriptMapping assumes that attaching sourcemaps get added to
`_contentScriptsBindings` or `_regularBindings`. Blackboxed sources
were skipped, for some reason, so detaching would throw an error.

In bad cases, navigations will detach sourcemaps, throw errors, and
prevent Console from clearing.

Bug:  888688 
Change-Id: I2c460271a868eca9a6d67371d9097cc552f20b56
Reviewed-on: https://chromium-review.googlesource.com/c/1295310
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601794}
[add] https://crrev.com/877430d2223351c42000a8fdef711514ca89e4df/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/blackboxed-sourcemap-detach-expected.txt
[add] https://crrev.com/877430d2223351c42000a8fdef711514ca89e4df/third_party/WebKit/LayoutTests/http/tests/devtools/bindings/blackboxed-sourcemap-detach.js
[modify] https://crrev.com/877430d2223351c42000a8fdef711514ca89e4df/third_party/blink/renderer/devtools/front_end/bindings/CompilerScriptMapping.js

Status: Fixed (was: Assigned)

Sign in to add a comment