New issue
Advanced search Search tips

Issue 888682 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Build-Toolchain

Blocking:
issue 878565



Sign in to add a comment

Crash-reporter unit test fails on kevin64

Project Member Reported by manojgupta@chromium.org, Sep 24

Issue description

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8934509417818697904

crash-reporter-0.0.1-r2878: [ RUN      ] UserCollectorTest.GetExecutableBaseNameFromPid
crash-reporter-0.0.1-r2878: [ERROR:crash_collector.cc(577)] Readlink failed on /proc/0/exe with 2
crash-reporter-0.0.1-r2878: [INFO:crash_collector.cc(603)] GetSymlinkTarget failed - Path /proc/0 DirectoryExists: 0
crash-reporter-0.0.1-r2878: [INFO:crash_collector.cc(610)] stat /proc/0/exe failed: -1 2
crash-reporter-0.0.1-r2878: ../../../../../../../tmp/portage/chromeos-base/crash-reporter-0.0.1-r2878/work/crash-reporter-0.0.1/crash-reporter/user_collector_test.cc:336: Failure
crash-reporter-0.0.1-r2878:       Expected: "crash_reporter_test"
crash-reporter-0.0.1-r2878: To be equal to: base_name
crash-reporter-0.0.1-r2878:       Which is: "cra"
crash-reporter-0.0.1-r2878: [  FAILED  ] UserCollectorTest.GetExecutableBaseNameFromPid (12 ms)


crash-reporter-0.0.1-r2878: [  FAILED  ] UserCollectorTest.GetExecutableBaseNameFromPid
crash-reporter-0.0.1-r2878: 
crash-reporter-0.0.1-r2878:  1 FAILED TEST
crash-reporter-0.0.1-r2878: Error: /var/cache/portage/chromeos-base/crash-reporter/out/Default/crash_reporter_test: failed with exit code 1
crash-reporter-0.0.1-r2878:  * ERROR: chromeos-base/crash-reporter-0.0.1-r2878::chromiumos failed (test phase):


 
 Issue 899796  has been merged into this issue.
Labels: -Pri-3 Pri-2
Owner: benchan@chromium.org
Status: Assigned (was: Untriaged)
Ben, can you take a look? This is currently the only issue which is stopping kevin64-release builder from turning green.
The unit test was executed unnder qemu and ran into this bug in qemu:

https://lists.gnu.org/archive/html/qemu-devel/2014-08/msg01210.html
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/62947e134ed150550b83b336f8c94c135da7fa3a

commit 62947e134ed150550b83b336f8c94c135da7fa3a
Author: Ben Chan <benchan@chromium.org>
Date: Sat Dec 15 06:40:40 2018

crash: replace CrashCollector::GetSymlinkTarget with base::ReadSymbolicLink

CrashCollector::GetSymlinkTarget() and base::ReadSymbolicLink()
implement the exact same functionality.

BUG= chromium:888682 
TEST=Run unit tests for amd64, arm, arm64 targets.

Change-Id: Ia7f27057e45167061729de8467db7c0649a35bea
Reviewed-on: https://chromium-review.googlesource.com/1376772
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/62947e134ed150550b83b336f8c94c135da7fa3a/crash-reporter/user_collector.h
[modify] https://crrev.com/62947e134ed150550b83b336f8c94c135da7fa3a/crash-reporter/crash_collector.h
[modify] https://crrev.com/62947e134ed150550b83b336f8c94c135da7fa3a/crash-reporter/user_collector_test.cc
[modify] https://crrev.com/62947e134ed150550b83b336f8c94c135da7fa3a/crash-reporter/crash_collector.cc
[modify] https://crrev.com/62947e134ed150550b83b336f8c94c135da7fa3a/crash-reporter/arc_collector.cc

Status: Verified (was: Assigned)
Thanks!

Sign in to add a comment