New issue
Advanced search Search tips

Issue 888675 link

Starred by 1 user
Status: Fixed
Owner:
michaelludwig@google.com
Closed: Oct 5
Cc:
robertph...@google.com
fmalita@chromium.org
bsalo...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rebaseline layout tests after Skia roll

Project Member Reported by michaelludwig@google.com, Sep 24 
The following layout tests:

virtual/gpu/fast/canvas/fillrect_gradient.html
virtual/gpu/fast/canvas/gradient-add-second-start-end-stop.html

were altered by the following Skia CL:

https://skia-review.googlesource.com/c/skia/+/155080 (
Implement an explicit binary search-based analytic gradient colorizer)
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d62c04a52d001bf62879a1b0b22e0ba030f9456

commit 8d62c04a52d001bf62879a1b0b22e0ba030f9456
Author: Michael Ludwig <michaelludwig@google.com>
Date: Mon Sep 24 22:47:24 2018

Suppress layout tests for Skia roll

Bug:  888675 
Change-Id: I511958c73dec8caf1c04daf582f7cc4e0752b745
Reviewed-on: https://chromium-review.googlesource.com/1241016
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593724}
[modify] https://crrev.com/8d62c04a52d001bf62879a1b0b22e0ba030f9456/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by michaelludwig@google.com, Oct 4 

Skia changes finally landed with https://skia-review.googlesource.com/c/skia/+/157569
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb4b9ea75c3b039492373f114ab63f44aee476bc

commit cb4b9ea75c3b039492373f114ab63f44aee476bc
Author: Florin Malita <fmalita@chromium.org>
Date: Fri Oct 05 14:54:50 2018

Rebaseline pending Skia suppressions

virtual/gpu/fast/canvas/canvas-arc-circumference.html
virtual/gpu/fast/canvas/canvas-drawImage-antiAlias.html
virtual/gpu/fast/canvas/canvas-ellipse-circumference.html
virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill.html
virtual/gpu/fast/canvas/fillrect_gradient.html
virtual/gpu/fast/canvas/gradient-add-second-start-end-stop.html
virtual/gpu-rasterization/images/cross-fade-background-size.html

TBR=

Bug: 884166, 889940 , 888675 , 802896 
Change-Id: I43312a60d4e8784cd915533bda5cf54141160adb
Reviewed-on: https://chromium-review.googlesource.com/c/1262895
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597120}
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/platform/win/virtual/gpu-rasterization/images/cross-fade-background-size-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-drawImage-antiAlias-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png
[add] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png
[modify] https://crrev.com/cb4b9ea75c3b039492373f114ab63f44aee476bc/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png

Comment 4 by michaelludwig@google.com, Oct 5

Status: Fixed (was: Assigned)
►

Sign in to add a comment