SSLError in my_activity.py on Windows |
||||
Issue description
$python my_activity.py
WARNING:root:Consider installing python-keyring
Traceback (most recent call last):
File "\src\depot_tools\my_activity.py", line 1092, in <module>
sys.exit(main())
File "\src\depot_tools\my_activity.py", line 1043, in main
my_activity.get_changes()
File "\src\depot_tools\my_activity.py", line 677, in get_changes
gerrit_changes = itertools.chain.from_iterable(gerrit_changes.get())
File "D:\src\depot_tools\win_tools-2_7_6_bin\python\bin\lib\multiprocessing\pool.py", line 554, in get
raise self._value
ssl.SSLError: [Errno 8] _ssl.c:507: EOF occurred in violation of protocol
@tandrii per latest change @ https://chromium-review.googlesource.com/1214707
,
Sep 24
,
Sep 24
Because I've never had an issue with this script and now it's consistent and such scripts are notorious for breaking on Windows... so I went with the latest change...
,
Sep 24
Bisecting locally, it's caused by https://chromium-review.googlesource.com/1173069, apologies for the initial missassignment, hadn't realized there'd been lots of recent changes in this file.
,
Sep 24
,
Sep 24
So review.coreboot.org uses a lets encrypt cert. If it's not in the root store then I think you get that error. This cl added the key to the store https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1173064 Your error says WARNING:root:Consider installing python-keyring, is windows using a different keystore?
,
Sep 24
I don't know how the keystore works on Windows. This warning has been there forever and has never been a problem for me. I think I tried installing that package on Windows in the past and failed (didn't bother to figure it out) Le lun. 24 sept. 2018 15 h 42, rrangel via monorail < monorail+v2.1231465064@chromium.org> a écrit :
,
Sep 24
Which python are you using? Is it the one that comes with depot_tools?
,
Sep 24
Looks like it : $ where python D:\src\depot_tools\python.bat C:\python_27_amd64\files\python.exe
,
Sep 24
let's revert for now, and rrangel@ can you reformulate as a platform-specific patch. I'll have to investigate the depot_tools supplied python, which I think should support this certificate (but it might be too old)
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/482d615b83e1a498a2cb3549dc3ad683bab3e78f commit 482d615b83e1a498a2cb3549dc3ad683bab3e78f Author: Gabriel Charette <gab@chromium.org> Date: Mon Sep 24 22:03:08 2018 Revert "my_activity: Add review.coreboot.org as a source" This reverts https://chromium-review.googlesource.com/1173069 It breaks my_activity.py on Windows. R=iannucci@chromium.org, rrangel@chromium.org Bug: 888641 Change-Id: I353489e52155d40e48e63819dc3016cf7dd59277 Reviewed-on: https://chromium-review.googlesource.com/1241133 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> [modify] https://crrev.com/482d615b83e1a498a2cb3549dc3ad683bab3e78f/my_activity.py
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19a81df0e723670b20498c4acdc8037265caec13 commit 19a81df0e723670b20498c4acdc8037265caec13 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Sep 24 23:23:40 2018 Roll src/third_party/depot_tools aaf2cc09c687..482d615b83e1 (2 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aaf2cc09c687..482d615b83e1 git log aaf2cc09c687..482d615b83e1 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 gab@chromium.org Revert "my_activity: Add review.coreboot.org as a source" 2018-09-24 ajp@chromium.org Revert "git cl upload: print response headers on 404 Gerrit RPC status." Created with: gclient setdep -r src/third_party/depot_tools@482d615b83e1 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:888641,chromium:881860 TBR=agable@chromium.org Change-Id: Ie6fea307792db8a9e8d4c06cd509e991985269c4 Reviewed-on: https://chromium-review.googlesource.com/1241595 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593739} [modify] https://crrev.com/19a81df0e723670b20498c4acdc8037265caec13/DEPS |
||||
►
Sign in to add a comment |
||||
Comment 1 by tandrii@chromium.org
, Sep 24Components: -Infra Infra>SDK
Owner: ----
Status: Untriaged (was: Assigned)