New issue
Advanced search Search tips

Issue 888634 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 816475



Sign in to add a comment

RTCDTMFSender-ontonechange.https.html is failing

Project Member Reported by jbroman@chromium.org, Sep 24

Issue description

e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/71778 (but appears across multiple bots going back some time)

New failures:
FAIL insertDTMF() with default duration and intertoneGap should fire tonechange events at the expected time assert_approx_equals: Expect tonechange event for "2" to be fired approximately after 170 milliseconds expected 170 +/- 400 but got 794
FAIL insertDTMF() with explicit duration and intertoneGap should fire tonechange events at the expected time assert_approx_equals: Expect tonechange event for "B" to be fired approximately after 170 milliseconds expected 170 +/- 400 but got 780
FAIL Calling insertDTMF() multiple times in the middle of tonechange events should cause future tonechanges to be updated the last provided tones assert_equals: Expect current event.tone to be 3 expected "3" but got "1"

Since I can't get the flakiness dashboard to show me when this started (but it wasn't in the last couple days), going to disable and leave to WebRTC folk to triage further.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a46b7fa7e2dfbb7d57344b5b662f68d7a33a0bc6

commit a46b7fa7e2dfbb7d57344b5b662f68d7a33a0bc6
Author: Jeremy Roman <jbroman@chromium.org>
Date: Mon Sep 24 18:24:20 2018

Mark external/wpt/webrtc/RTCDTMFSender-ontonechange.https.html as failing.

Bug:  888634 
Change-Id: I81df8a179f925e6dcb07bbdec118f407f3395567
No-Try: true
Tbr: jbroman@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1240520
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593605}
[modify] https://crrev.com/a46b7fa7e2dfbb7d57344b5b662f68d7a33a0bc6/third_party/WebKit/LayoutTests/TestExpectations

Owner: hta@chromium.org
Status: Assigned (was: Untriaged)
hta@: Can you take a look?
Will do. This is likely a test that used to fail at a previous step, but is now failing because of the timeout.
We need to rewire the logic so that a timeout is not part of the test suite.

Blockedon: 816475
Status: Fixed (was: Assigned)
Fix was landed as an update to  https://crbug.com/816475 

Sign in to add a comment