New issue
Advanced search Search tips

Issue 888618 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug

Blocking:
issue 888236



Sign in to add a comment

'Check failed: parent' in blink::StyleEngine::RecalcStyle during external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-mode-disabled.html in debug

Project Member Reported by jbroman@chromium.org, Sep 24

Issue description

Owner: futhark@chromium.org
Status: Assigned (was: Untriaged)
https://chromium-review.googlesource.com/c/chromium/src/+/1238728 appears to be responsible (verified locally).
Summary: 'Check failed: parent' in blink::StyleEngine::RecalcStyle during external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-mode-disabled.html in debug (was: 'Check failed: parent' in blink::StyleEngine::RecalcStyle during external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-mode-disabled.html on Win7 debug)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e092f9c13e351034e12388bbb8bd77d922b616e8

commit e092f9c13e351034e12388bbb8bd77d922b616e8
Author: Jeremy Roman <jbroman@chromium.org>
Date: Mon Sep 24 17:50:10 2018

Revert "Workaround for nested remove for datalists."

This reverts commit f76237333778b789b112dfb693a55631a69020bd.

Reason for revert: causes DCHECK failures in external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-mode-disabled.html

Original change's description:
> Workaround for nested remove for datalists.
> 
> Nested removes confuses the style traversal roots. Make this a general
> workaround for UA shadow removals.
> 
> Bug:  888236 , 888448
> Change-Id: Ia0165e7478c96282900a8191eeac18ae34586a2c
> Reviewed-on: https://chromium-review.googlesource.com/1238728
> Reviewed-by: Anders Ruud <andruud@chromium.org>
> Commit-Queue: Rune Lillesveen <futhark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593510}

TBR=futhark@chromium.org,andruud@chromium.org

Change-Id: I843b4cc5d9be74fea13ff43305b0093fd64dcae3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  888236 , 888448,  888618 
Reviewed-on: https://chromium-review.googlesource.com/1240505
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593592}
[delete] https://crrev.com/a3d55f3d90dab08b9370ee62889525f494e52298/third_party/WebKit/LayoutTests/fast/css/style-traversal-root-datalist-crash.html
[modify] https://crrev.com/e092f9c13e351034e12388bbb8bd77d922b616e8/third_party/blink/renderer/core/css/style_engine.cc

Status: Fixed (was: Assigned)
Reopened  issue 888236  instead.
Blocking: 888236
Issue 888902 has been merged into this issue.

Sign in to add a comment