Polish animations for home launcher swipe to show/hide animation. |
|||||||||
Issue descriptionRight now the animations have a constant placeholder at 250 ms and some placeholder tween and replacement values. Also does not account for fling velocities. They should instead follow the values that laptop mode app list uses.
,
Oct 8
,
Oct 9
newcomer: If you could point me to some locations in the code where the peeking launcher logics and values lie, that would be very helpful!
,
Oct 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76 commit 31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76 Author: Sammie Quon <sammiequon@google.com> Date: Sat Oct 13 04:06:39 2018 applist: Add fling to home launcher swipe to show/hide. We can now fling to show or hide launcher. Uses same threshold as in app list view. Also change app list show/hide from a shelf button to use longer animation, to match ux spec. Test: ash_unittests HomeLauncherGestureHandlerTest.Fling* Bug: 888617 Change-Id: I73de8ad6fdeace7f9ef34124eb2e5741e92b3371 Reviewed-on: https://chromium-review.googlesource.com/c/1279296 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599484} [modify] https://crrev.com/31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76/ash/app_list/app_list_controller_impl.h [modify] https://crrev.com/31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76/ash/app_list/app_list_view_delegate.h [modify] https://crrev.com/31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76/ash/app_list/home_launcher_gesture_handler.cc [modify] https://crrev.com/31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76/ash/app_list/home_launcher_gesture_handler.h [modify] https://crrev.com/31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76/ash/app_list/home_launcher_gesture_handler_unittest.cc [modify] https://crrev.com/31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76/ash/app_list/test/app_list_test_view_delegate.cc [modify] https://crrev.com/31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76/ash/app_list/test/app_list_test_view_delegate.h [modify] https://crrev.com/31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76/ash/shell/app_list.cc
,
Oct 13
,
Oct 14
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6844323873cbbdba4be8db75e468c843b44a939 commit e6844323873cbbdba4be8db75e468c843b44a939 Author: Sammie Quon <sammiequon@google.com> Date: Mon Oct 15 18:13:11 2018 [merge to 71] applist: Add fling to home launcher swipe to show/hide. We can now fling to show or hide launcher. Uses same threshold as in app list view. Also change app list show/hide from a shelf button to use longer animation, to match ux spec. TBR=sammiequon@google.com (cherry picked from commit 31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76) Test: ash_unittests HomeLauncherGestureHandlerTest.Fling* Bug: 888617 Change-Id: I73de8ad6fdeace7f9ef34124eb2e5741e92b3371 Reviewed-on: https://chromium-review.googlesource.com/c/1279296 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599484} Reviewed-on: https://chromium-review.googlesource.com/c/1280554 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#24} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/e6844323873cbbdba4be8db75e468c843b44a939/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/e6844323873cbbdba4be8db75e468c843b44a939/ash/app_list/app_list_controller_impl.h [modify] https://crrev.com/e6844323873cbbdba4be8db75e468c843b44a939/ash/app_list/app_list_view_delegate.h [modify] https://crrev.com/e6844323873cbbdba4be8db75e468c843b44a939/ash/app_list/home_launcher_gesture_handler.cc [modify] https://crrev.com/e6844323873cbbdba4be8db75e468c843b44a939/ash/app_list/home_launcher_gesture_handler.h [modify] https://crrev.com/e6844323873cbbdba4be8db75e468c843b44a939/ash/app_list/home_launcher_gesture_handler_unittest.cc [modify] https://crrev.com/e6844323873cbbdba4be8db75e468c843b44a939/ash/app_list/test/app_list_test_view_delegate.cc [modify] https://crrev.com/e6844323873cbbdba4be8db75e468c843b44a939/ash/app_list/test/app_list_test_view_delegate.h [modify] https://crrev.com/e6844323873cbbdba4be8db75e468c843b44a939/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/e6844323873cbbdba4be8db75e468c843b44a939/ash/shelf/shelf_layout_manager.cc [modify] https://crrev.com/e6844323873cbbdba4be8db75e468c843b44a939/ash/shell/app_list.cc
,
Oct 15
Bulk moving all M-71 <P-1's to M-72.
,
Oct 15
,
Oct 15
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6844323873cbbdba4be8db75e468c843b44a939 Commit: e6844323873cbbdba4be8db75e468c843b44a939 Author: sammiequon@google.com Commiter: sammiequon@chromium.org Date: 2018-10-15 18:13:11 +0000 UTC [merge to 71] applist: Add fling to home launcher swipe to show/hide. We can now fling to show or hide launcher. Uses same threshold as in app list view. Also change app list show/hide from a shelf button to use longer animation, to match ux spec. TBR=sammiequon@google.com (cherry picked from commit 31ce8f8b5bd1f7a74e25b53d7b920f20427f6e76) Test: ash_unittests HomeLauncherGestureHandlerTest.Fling* Bug: 888617 Change-Id: I73de8ad6fdeace7f9ef34124eb2e5741e92b3371 Reviewed-on: https://chromium-review.googlesource.com/c/1279296 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599484} Reviewed-on: https://chromium-review.googlesource.com/c/1280554 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#24} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by newcomer@chromium.org
, Sep 27