New issue
Advanced search Search tips

Issue 888602 link

Starred by 1 user
Status: Fixed
Owner:
tiborg@chromium.org
Closed: Sep 26
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-VR
Proj-XR-AR
Proj-XR



Sign in to add a comment

AR instrumentation tests failing due to strict mode violation

Project Member Reported by bsheedy@chromium.org, Sep 24 
Since https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Oreo%20Phone%20Tester/950, the AR instrumentation tests have been failing 100% of the time due to a strict mode violation. Suspected culprit is https://chromium-review.googlesource.com/c/chromium/src/+/1228308.

Stack:

09-21 18:29:17.375  7375  7375 D StrictMode: StrictMode policy violation; ~duration=102 ms: android.os.StrictMode$StrictModeDiskReadViolation: policy=18153535 violation=2
09-21 18:29:17.375  7375  7375 D StrictMode: 	at android.os.StrictMode$AndroidBlockGuardPolicy.onReadFromDisk(StrictMode.java:1438)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at java.io.UnixFileSystem.checkAccess(UnixFileSystem.java:251)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at java.io.File.exists(File.java:807)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at android.app.ContextImpl.ensurePrivateDirExists(ContextImpl.java:559)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at android.app.ContextImpl.ensurePrivateDirExists(ContextImpl.java:550)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at android.app.ContextImpl.getFilesDir(ContextImpl.java:595)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at android.content.ContextWrapper.getFilesDir(ContextWrapper.java:226)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at com.google.android.play.core.splitcompat.SplitCompat.<init>(Unknown Source:14)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at com.google.android.play.core.splitcompat.SplitCompat.a(Unknown Source:21)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at com.google.android.play.core.splitcompat.SplitCompat.install(Unknown Source:1)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at org.chromium.components.module_installer.ModuleInstaller.init(ModuleInstaller.java:44)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at org.chromium.chrome.browser.vr.ArCoreJavaUtils.initializeAppInfo(ArCoreJavaUtils.java:130)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at org.chromium.chrome.browser.vr.ArCoreJavaUtils.<init>(ArCoreJavaUtils.java:100)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at org.chromium.chrome.browser.vr.ArCoreJavaUtils.create(ArCoreJavaUtils.java:89)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at android.os.MessageQueue.nativePollOnce(Native Method)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at android.os.MessageQueue.next(MessageQueue.java:325)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at android.os.Looper.loop(Looper.java:142)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at android.app.ActivityThread.main(ActivityThread.java:6541)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at java.lang.reflect.Method.invoke(Native Method)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
09-21 18:29:17.375  7375  7375 D StrictMode: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

Comment 1 by tiborg@chromium.org, Sep 24

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4397d75c3bd54382c67ef875b6c69fd3115922a2

commit 4397d75c3bd54382c67ef875b6c69fd3115922a2
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Wed Sep 26 13:58:30 2018

[feature modules] Allow disk writes for SplitCompat.install

Bug:  888602 
Change-Id: I9ac5818460da30057a42fff007dbcceb52b6f6a2
Reviewed-on: https://chromium-review.googlesource.com/1244599
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594302}
[modify] https://crrev.com/4397d75c3bd54382c67ef875b6c69fd3115922a2/components/module_installer/android/java/src/org/chromium/components/module_installer/ModuleInstaller.java

Comment 3 by tiborg@chromium.org, Sep 26

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 20

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/396bfd307c865a4332529f1279ddc9ee23cac4f3

commit 396bfd307c865a4332529f1279ddc9ee23cac4f3
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Tue Nov 20 22:54:26 2018

Revert "[feature modules] Allow disk writes for SplitCompat.install"

This reverts commit 4397d75c3bd54382c67ef875b6c69fd3115922a2.

Reason for revert: only needed for bundles but we don't build bundles
for M72.

Original change's description:
> [feature modules] Allow disk writes for SplitCompat.install
>
> Bug:  888602 
> Change-Id: I9ac5818460da30057a42fff007dbcceb52b6f6a2
> Reviewed-on: https://chromium-review.googlesource.com/1244599
> Reviewed-by: agrieve <agrieve@chromium.org>
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594302}

TBR=agrieve@chromium.org

Bug:  899574 
Change-Id: I87363d49be2c0657c41bbf97004c19ed86980018
Reviewed-on: https://chromium-review.googlesource.com/c/1344907
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#779}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/396bfd307c865a4332529f1279ddc9ee23cac4f3/components/module_installer/android/java/src/org/chromium/components/module_installer/ModuleInstaller.java

Comment 5 by tiborg@chromium.org, Nov 20 

Only reverted in M71. ToT still has it.
►

Sign in to add a comment