New issue
Advanced search Search tips

Issue 888571 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

middleClickAutoscroll-latching.html doesn't call second test

Project Member Reported by masonfreed@chromium.org, Sep 24

Issue description

The middleClickAutoscroll-latching.html layout test appears to have a bug. There are two tests contained within the html, "testBubble" and "testIFrame", and the code in testBubble appears to try to call testIFrame after it succeeds. But that call happens after testBubble.done(), which causes testIFrame() to not get hit.
 
I would like to take this issue :)
Cc: jdragon....@gmail.com
Owner: masonfreed@chromium.org
CCing jdragon.bae@gmail.com and adding myself as the owner for now.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dcc25c6ba139f655078df8c28df8e4c2395f380

commit 8dcc25c6ba139f655078df8c28df8e4c2395f380
Author: Jaeyong Bae <jdragon.bae@gmail.com>
Date: Tue Oct 09 15:02:27 2018

Fix execution flow in middleClickAutoscroll test

This patch means change flow of testIFrame test.

Bug:  888571 
Change-Id: Iec7ed393a56a407a6715fe2baf1f4cc0b067b1bc
Reviewed-on: https://chromium-review.googlesource.com/c/1241114
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597916}
[modify] https://crrev.com/8dcc25c6ba139f655078df8c28df8e4c2395f380/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/8dcc25c6ba139f655078df8c28df8e4c2395f380/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-latching.html

Status: Fixed (was: Available)
Nice work jdragon.bae@

Sign in to add a comment